Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanox: re-enable generated tests #43

Closed
emturner opened this issue Oct 4, 2023 · 1 comment · Fixed by #46
Closed

Nanox: re-enable generated tests #43

emturner opened this issue Oct 4, 2023 · 1 comment · Fixed by #46
Assignees
Labels
app::wallet issues relating to the wallet app device::NANOX Issues affecting NANOX device tests test - related isues

Comments

@emturner
Copy link
Collaborator

emturner commented Oct 4, 2023

Disabled in #22.

The OCR system was completely re-done in the SDK version used in #22 - rather than using OCR, instead the actual bitmaps are extracted from the elf binaries and are used to get info off the screen. (See LedgerHQ/speculos#418 for context)

We will likely have to talk to Ledger to confirm the issue

@spalmer25
Copy link
Collaborator

After some experimentation, in some cases, the result of $URL/events?currentscreenonly=true does not seem to correspond to what is actually on the screen.
For example, if the screen contains a _, a - or a ~, then the result is truncated starting from this character.

@spalmer25 spalmer25 linked a pull request Oct 5, 2023 that will close this issue
@emturner emturner added tests test - related isues app::wallet issues relating to the wallet app device::NANOX Issues affecting NANOX device labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app::wallet issues relating to the wallet app device::NANOX Issues affecting NANOX device tests test - related isues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants