Add 'offline' option to ledgerctl CLI install command. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrojean-ledger
force-pushed
the
add-installation-dump-option
branch
3 times, most recently
from
a851c09
to
6507f53
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 20 21 +1
Lines 1255 1330 +75
======================================
- Misses 1255 1330 +75 ☔ View full report in Codecov by Sentry. |
agrojean-ledger
force-pushed
the
add-installation-dump-option
branch
from
6507f53
to
dc182fd
Compare
agrojean-ledger
force-pushed
the
add-installation-dump-option
branch
from
c32e939
to
ad8dd1f
Compare
agrojean-ledger
force-pushed
the
add-installation-dump-option
branch
from
ad09375
to
5182c6e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
xchapron-ledger
approved these changes
Dec 6, 2023
agrojean-ledger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--offlineoption to theinstallCLI command to dump the APDU file instead of trying to install it to a physical device.The target id is extracted from the manifest.
For rust apps
Next steps :
ledgerctl install --offline myfile --manifest mymanifestfromcargo-ledgerwhen the build command is invoked to generate the apdu file automatically. Support new ELF metadata + Add APDU dump with new Ledgerctl option cargo-ledger#31