Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ledgerctl (full, legacy) + Bump Stax SDK #91

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Add ledgerctl (full, legacy) + Bump Stax SDK #91

merged 4 commits into from
Dec 11, 2023

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Oct 12, 2023 •
edited
Loading

@agrojean-ledger agrojean-ledger mentioned this pull request Oct 12, 2023
Merged
xchapron-ledger
xchapron-ledger reviewed Oct 12, 2023
View reviewed changes
full/Dockerfile Outdated Show resolved Hide resolved
@agrojean-ledger agrojean-ledger mentioned this pull request Dec 11, 2023
Merged
xchapron-ledger
xchapron-ledger reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master?

xchapron-ledger
xchapron-ledger reviewed Dec 11, 2023
View reviewed changes
lite/Dockerfile Outdated Show resolved Hide resolved
xchapron-ledger
xchapron-ledger reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name of the Pr could be changed to be more generic as it doesn't impact only the full image.

@agrojean-ledger agrojean-ledger changed the title full : add ledgerctl (it is a dependency of cargo ledger) Add ledgerctl (full, legacy) + Bump Stax SDK Dec 11, 2023
@agrojean-ledger
Copy link
Contributor Author

name of the Pr could be changed to be more generic as it doesn't impact only the full image.

@xchapron-ledger done

@agrojean-ledger agrojean-ledger merged commit a5e4a50 into master Dec 11, 2023
3 checks passed
@agrojean-ledger agrojean-ledger deleted the add-ledger-ctl branch December 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrojean-ledger @xchapron-ledger