Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lens class refactor #269

Merged
merged 92 commits into from
Nov 7, 2024
Merged

Lens class refactor #269

merged 92 commits into from
Nov 7, 2024

Conversation

nkhadka21
Copy link
Collaborator

This PR refactors the Lens Class and implements multi-source lens.

nkhadka21 and others added 30 commits October 8, 2024 12:34
@nkhadka21
added false_positive and false_positive_pop.
a9f3cfa
@nkhadka21
cleaned up FalsePositive class.
49d9633
@nkhadka21
cleaned up FalsePositivePop class.
ddf9654
@nkhadka21
added a z_min parameter in source_draw() in Galaxies class.
e202f79
@nkhadka21
cleaned up FalsePositivePop class
61be783
@nkhadka21
minor change
3ad8955
@nkhadka21
cleaned up few minor thing in false positive
63536dd
@nkhadka21
Minor change in false positive
4b862c8
@nkhadka21
Merge branch 'main' of https://github.com/nkhadka21/slsim into false_…
9e0ae48 
…positive

merged to main.
@nkhadka21
minor changes in Source and Lens class input.
b97c7de
@nkhadka21
Change in lens class with recent input change.
6badfd1
@nkhadka21
Change in lens class with recent input change.
b890b6f
@nkhadka21
Change in lens class with recent input change.
9f4ab92
@nkhadka21
added a test area in LensPop's random draw function.
074a607
@nkhadka21
added multiple source in FalsePositive and FalsePositivePop class.
826e670
@nkhadka21
minor change
af77240
@nkhadka21
added test functions for the false positive.
742bbd1
@nkhadka21
added test functions for the false positive.
41e62b9
@nkhadka21
corrected some test functions with added features.
224ac6f
@nkhadka21
corrected some test functions with added features.
aac4d0c
@nkhadka21
corrected some test functions with added features.
da3def4
@nkhadka21
improved false positive test.
85d8999
@nkhadka21
improved false positive pop test.
20cdf1e
@nkhadka21
improved false positive pop test.
55e58ee
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a4b05a9 
for more information, see https://pre-commit.ci
@nkhadka21
minor change.
1f9bd1b
@nkhadka21
Merge branch 'false_positive' of https://github.com/nkhadka21/slsim i…
691100a 
…nto false_positive

merged to remote
@nkhadka21
added a notebook
fc29a62
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d7c71ac 
for more information, see https://pre-commit.ci
@nkhadka21
improved test function in galaxies
f96ceb0
@nkhadka21 nkhadka21 requested a review from sibirrer November 4, 2024 22:09
sibirrer
sibirrer requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
We need to update the Lens() classes with the specific redshift to make it work with multiple source redshifts. I hopefully can push the changes tomorrow to make a new release of lenstronomy

slsim/lens.py Outdated Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
tests/test_lens.py Show resolved Hide resolved
@nkhadka21
Copy link
Collaborator Author

Thank you very much @sibirrer ! Waiting for the lenstronomy update.

sibirrer
sibirrer requested changes Nov 6, 2024
View reviewed changes
slsim/lens.py Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
slsim/lens.py Outdated Show resolved Hide resolved
tests/test_roman_image_simulation.py Show resolved Hide resolved
@nkhadka21 nkhadka21 requested a review from sibirrer November 6, 2024 20:58
sibirrer
sibirrer approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @nkhadka21 . I have one minor comment but already approve this PR

slsim/lens.py Show resolved Hide resolved
@nkhadka21 nkhadka21 merged commit 5cc87c5 into LSST-strong-lensing:main Nov 7, 2024
2 of 5 checks passed
@nkhadka21 nkhadka21 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibirrer sibirrer sibirrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkhadka21 @sibirrer