Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Lens class refactor" #272

Closed
wants to merge 1 commit into from
Closed

Conversation

nkhadka21
Copy link
Collaborator

Reverts #269

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nkhadka21 nkhadka21 marked this pull request as ready for review November 7, 2024 00:56
@nkhadka21 nkhadka21 closed this Nov 7, 2024
@nkhadka21 nkhadka21 reopened this Nov 7, 2024
@nkhadka21 nkhadka21 closed this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 90.05525% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (5cc87c5) to head (401b105).

Files with missing lines Patch % Lines
slsim/LsstSciencePipeline/lsst_science_pipeline.py 75.75% 8 Missing ⚠️
slsim/lens_pop.py 28.57% 5 Missing ⚠️
slsim/lens.py 95.55% 4 Missing ⚠️
slsim/LsstSciencePipeline/opsim_pipeline.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   97.37%   90.12%   -7.26%     
==========================================
  Files          71       72       +1     
  Lines        4873     5203     +330     
==========================================
- Hits         4745     4689      -56     
- Misses        128      514     +386     
Files with missing lines Coverage Δ
slsim/Deflectors/elliptical_lens_galaxies.py 94.91% <ø> (ø)
slsim/Sources/galaxies.py 99.29% <100.00%> (ø)
slsim/Sources/source.py 99.00% <100.00%> (+0.42%) ⬆️
slsim/image_simulation.py 100.00% <100.00%> (ø)
slsim/lensed_system_base.py 71.87% <100.00%> (+7.94%) ⬆️
slsim/LsstSciencePipeline/opsim_pipeline.py 39.06% <95.00%> (ø)
slsim/lens.py 96.62% <95.55%> (+3.85%) ⬆️
slsim/lens_pop.py 87.87% <28.57%> (-12.13%) ⬇️
slsim/LsstSciencePipeline/lsst_science_pipeline.py 14.54% <75.75%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant