Merklization audit #157
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,15 +12,20 @@ | |
| // You should have received a copy of the Apache 2.0 License along with this | ||
| // software. If not, see <https://opensource.org/licenses/Apache-2.0>. | ||
|
|
||
| use std::fs; | ||
| use std::io::Write; | ||
|
|
||
| use commit_verify::stl::commit_verify_stl; | ||
| use commit_verify::{mpc, CommitmentLayout, MerkleNode}; | ||
| use strict_types::stl::{std_stl, strict_types_stl}; | ||
| use strict_types::{parse_args, SystemBuilder}; | ||
|
|
||
| fn main() { | ||
| let lib = commit_verify_stl(); | ||
| let (format, dir) = parse_args(); | ||
| lib.serialize( | ||
| format, | ||
| dir.as_ref(), | ||
| "0.1.0", | ||
| Some( | ||
| " | ||
|
|
@@ -31,4 +36,56 @@ fn main() { | |
| ), | ||
| ) | ||
| .expect("unable to write to the file"); | ||
|
|
||
| let dir = dir.unwrap_or_else(|| ".".to_owned()); | ||
|
|
||
| let std = std_stl(); | ||
| let st = strict_types_stl(); | ||
| let cv = commit_verify_stl(); | ||
|
|
||
| let sys = SystemBuilder::new() | ||
| .import(cv) | ||
| .unwrap() | ||
| .import(st) | ||
| .unwrap() | ||
| .import(std) | ||
| .unwrap() | ||
| .finalize() | ||
| .expect("not all libraries present"); | ||
|
|
||
| let mut file = fs::File::create(format!("{dir}/Merkle.vesper")).unwrap(); | ||
| writeln!( | ||
| file, | ||
| "{{- | ||
| Description: Merklization and MPC workflows | ||
| Author: Dr Maxim Orlovsky <[email protected]> | ||
| Copyright (C) 2024 LNP/BP Standards Association. All rights reserved. | ||
| License: Apache-2.0 | ||
| -}} | ||
|
|
||
| Merklization vesper lexicon=types+commitments | ||
| " | ||
| ) | ||
| .unwrap(); | ||
| writeln!(file, "\n-- General merklization workflows\n").unwrap(); | ||
| let layout = MerkleNode::commitment_layout(); | ||
| writeln!(file, "{layout}").unwrap(); | ||
| let tt = sys.type_tree("CommitVerify.MerkleNode").unwrap(); | ||
| writeln!(file, "{tt}").unwrap(); | ||
|
|
||
| writeln!(file, "\n-- Multi-protocol commitment workflows\n").unwrap(); | ||
| let layout = mpc::Leaf::commitment_layout(); | ||
| writeln!(file, "{layout}").unwrap(); | ||
| let tt = sys.type_tree("CommitVerify.Leaf").unwrap(); | ||
| writeln!(file, "{tt}").unwrap(); | ||
|
|
||
| let layout = mpc::MerkleBlock::commitment_layout(); | ||
| writeln!(file, "{layout}").unwrap(); | ||
| let tt = sys.type_tree("CommitVerify.MerkleBlock").unwrap(); | ||
| writeln!(file, "{tt}").unwrap(); | ||
|
|
||
| let layout = mpc::MerkleTree::commitment_layout(); | ||
| writeln!(file, "{layout}").unwrap(); | ||
| let tt = sys.type_tree("CommitVerify.MerkleTree").unwrap(); | ||
| writeln!(file, "{tt}").unwrap(); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,36 @@ | ||
| -----BEGIN STRICT TYPE LIB----- | ||
| Id: 7qvjR4HCwJKF3mxE5GqsAaADces5JDRwb8ajAse9mkz3#exhibit-karate-ritual | ||
| Name: CommitVerify | ||
| Dependencies: | ||
| DzTvt9gGhPUKD8Dkkjk9PDBhkJ4gtWxXWQjxnmUYLNrs#voyage-kimono-disco | ||
|
|
||
| 3`1{iZE18?WpZg|c>%!$%tl@;WNu_lcw-g2$nLVb<*lb*ENIx0;35YAw}=B%bYuY | ||
| oQ*>kj0A^Tl*p6J$36SYb7g#;qpQBTpwL(~+!(f@;t~vt?k^)sV3;+s4Z*6U9bZu | ||
| pBbOiwb2LJ#-AOHkRWnpFn0uTvlZfId*X>?^|00sgGaB^>SZ)0z40Wg(*<{e=)S- | ||
| S-Y<l(P9Y9YVY`}-X+f~R@qMRed+u?KBsb8}&5WdSuesZkZk>V@1=_p5>Oab-~jC | ||
| R3C`SFec^=zG+gvC|O;Wo~qGZ*X}41_B3VZgg^QaCra#2m^3$a{vGY3r%HmYiwmg | ||
| Y;R+01_T9UWpH$80>K2#MqVsrZe&e(V->r|?y|b&t*2isXxNhAA_oAsh-O%D*p6J | ||
| $36SYb7g#;qpQBTpwL(~+!(f@;t~vt?k_cmOW?^G=Z*l+t0t{nvZ*y}~Wn*+{Z*B | ||
| kx0ob*<mh)A>-9G+(AKhLw+s!eDmlO2>&}_PPHjCBJR{;P3000000RR90{{R3000 | ||
| (7mbaHQSc>n|g00eGtZe;)f009JZZ*64&1pxp62ntPQa%*g5NMUnm1pxpD002NB0 | ||
| 18cIa%*g5PH$vo1_cRXa$#;`XlZU|0lQ3Y3mf3jZajR1t6%zV^Qs{9ch%g}Wy;2! | ||
| c7I|^!UbeyaCB$@009MeX=HS0001BbZf|5|F#$N9Lxv|61vo|<S$`kJ6oIZx{|tq | ||
| &1{dNqe!iO(;xh$qZ)9aM0XUvRh9?yTI7S;;e;>sZfv!yd427@;7veO2zMB=|GYd | ||
| ^+a%*g5P;zf?W(ETTaBp(}00anQZ)Ra*bZ>G100IPXVRUE!2mv^rLxv|61vo|<S$ | ||
| `kJ6oIZx{|tq&1{dNqe!iO(;xhmM00000001BW00000000V2WpZn5WmIxyWd;QWW | ||
| My!4Xad0m%tl@;WNu_lcw-g2$nLVb<*lb*ENIx0;35YAw}@s~aM+Gq(Fu_0Ocz)^ | ||
| +@GUUoV7w&pu=F9->y0X3z7$AZgg^QaCra#2nb_uW?^G=Z*l+t0tjtob8}&5Wpe- | ||
| u0Wg(*<{e=)S-S-Y<l(P9Y9YVY`}-X+f~R@qMRed+u>mzVsZkZk>V@1=_p5>Oab- | ||
| ~jCR3C`SFec^=zG+gvC{wm0000000960{{R30000ARVQ>Hn000C41p)yum44<OVK | ||
| iC01qkHfuRUrZzt;Qv9WjEZdF4fP;8w8#H8-hI70Bv^+*0?ef%0)>Q3WPbltNdpi | ||
| 4*91)SI!>0000000000|Ns90000002Tf&jb75y?1pxpD002NB01ZxWWMx8fVQyn+ | ||
| X>Ml&0|a(&X=DHfb7^j8Y-IrkVsc?_V`u^jP;zf{Z)0z4Nn`~900#g7Kp+4LQ*?4 | ||
| ^V{}Mib7%zt00#g7Kp+4JRB~lyPH$vo1OfmJV{dL_WnpY(WKM5nWdH^O1!QG#bZ7 | ||
| #>1k6TWEM#tEO?YD!yU6acy5+5>Uo2?YlHei-0Jn%{Sa8^mT+s=T=}Z?`J=~w8Q= | ||
| GLzSfImTncuED0}GM_Xkl|`0XUvRh9?yTI7S;;e;>sZfv!yd427@;7veO2zMB=|G | ||
| XV}`Z*6U9bZupBbWCMoW&j2P3UG37bZ=vCY)NDRFqMAh9bq(Cy9Eg3;jcYvA-~r9 | ||
| `yDZYr+MW?bl_I82W@3@b75y?0W~+NQ5DGQh1^p2tAX-yWl;qtQ<OqiuZa`rd(@k | ||
| ;(* | ||
|
|
||
| -----END STRICT TYPE LIB----- | ||
|
|
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| {- | ||
| Description: Merklization and MPC workflows | ||
| Author: Dr Maxim Orlovsky <[email protected]> | ||
| Copyright (C) 2024 LNP/BP Standards Association. All rights reserved. | ||
| License: Apache-2.0 | ||
| -} | ||
|
|
||
| Merklization vesper lexicon=types+commitments | ||
|
|
||
|
|
||
| -- General merklization workflows | ||
|
|
||
| MerkleHash commitment hasher=SHA256 tagged=urn:ubideco:merkle:node#2024-01-31 | ||
| MerkleNode serialized | ||
|
|
||
| MerkleNode rec | ||
| branching enum void=0 single=1 branch=2 -- NodeBranching | ||
| depth is U8 | ||
| width is U256 | ||
| node1 bytes len=32 aka=MerkleHash | ||
| node2 bytes len=32 aka=MerkleHash | ||
|
|
||
|
|
||
| -- Multi-protocol commitment workflows | ||
|
|
||
| MerkleHash commitment hasher=SHA256 tagged=urn:ubideco:merkle:node#2024-01-31 | ||
| Leaf serialized | ||
|
|
||
| Leaf union | ||
| inhabited rec tag=0 | ||
| protocol bytes len=32 aka=ProtocolId | ||
| message bytes len=32 aka=Message | ||
| entropy rec tag=1 | ||
| entropy is U64 | ||
| pos is U32 | ||
|
|
||
| Commitment commitment hasher=SHA256 tagged=urn:ubideco:mpc:commitment#2024-01-31 | ||
| MerkleBlock concealed concealed=MerkleBlock | ||
|
|
||
| MerkleBlock rec | ||
| depth enum { | ||
| _0=0 _1=1 _2=2 _3=3 _4=4 _5=5 _6=6 _7=7 _8=8 | ||
| _9=9 _10=10 _11=11 _12=12 _13=13 _14=14 _15=15 _16=16 | ||
| _17=17 _18=18 _19=19 _20=20 _21=21 _22=22 _23=23 _24=24 | ||
| _25=25 _26=26 _27=27 _28=28 _29=29 _30=30 _31=31 | ||
| } -- U5 | ||
| cofactor is U16 | ||
| crossSection list len=1..MAX32 | ||
| TreeNode union | ||
| concealedNode rec tag=0 | ||
| depth enum { | ||
| _0=0 _1=1 _2=2 _3=3 _4=4 _5=5 _6=6 _7=7 _8=8 | ||
| _9=9 _10=10 _11=11 _12=12 _13=13 _14=14 _15=15 _16=16 | ||
| _17=17 _18=18 _19=19 _20=20 _21=21 _22=22 _23=23 _24=24 | ||
| _25=25 _26=26 _27=27 _28=28 _29=29 _30=30 _31=31 | ||
| } -- U5 | ||
| hash bytes len=32 aka=MerkleHash | ||
| commitmentLeaf rec tag=1 | ||
| protocolId bytes len=32 aka=ProtocolId | ||
| message bytes len=32 aka=Message | ||
| some is U64 option wrapped tag=1 | ||
|
|
||
| Commitment commitment hasher=SHA256 tagged=urn:ubideco:mpc:commitment#2024-01-31 | ||
| MerkleBlock concealed concealed=MerkleBlock | ||
|
|
||
| MerkleTree rec | ||
| depth enum { | ||
| _0=0 _1=1 _2=2 _3=3 _4=4 _5=5 _6=6 _7=7 _8=8 | ||
| _9=9 _10=10 _11=11 _12=12 _13=13 _14=14 _15=15 _16=16 | ||
| _17=17 _18=18 _19=19 _20=20 _21=21 _22=22 _23=23 _24=24 | ||
| _25=25 _26=26 _27=27 _28=28 _29=29 _30=30 _31=31 | ||
| } -- U5 | ||
| entropy is U64 | ||
| cofactor is U16 | ||
| messages map len=0..MAX24 | ||
|
There was a problem hiding this comment. Similar to question above, we dont need at least one message in the merkle tree? There was a problem hiding this comment. Hm.. On one side no: we may have a merkle tree made of entropy (and its cross-section still will not be an empty set). However this has low utility, so it could be we can prohibit that... There was a problem hiding this comment. Giving a second thought: there might be a need to tress with no messages and just an entropy. While it's marginal, even if we require a non-empty message set, people can fake it and still produce trees containing no real messages. Thus, while it is mathematically impossible to have a tree cross-section which is empty, it is mathematically possible to have a tree with no messages, made only of entropy - thus, the difference in these types. |
||
| key bytes len=32 aka=ProtocolId | ||
| value bytes len=32 aka=Message | ||
| map map len=0..MAX24 | ||
| key is U32 | ||
| value tuple | ||
| _ bytes len=32 aka=ProtocolId | ||
| _ bytes len=32 aka=Message | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming:
I reread LNPBP-4 because of this change and in fact, we will always have at least one commiment in the MPC. This change reflects the statement above, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct