-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merklization audit #157
Merklization audit #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be right, but see my comments, please.
_25=25 _26=26 _27=27 _28=28 _29=29 _30=30 _31=31 | ||
} -- U5 | ||
cofactor is U16 | ||
crossSection list len=1..MAX32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming:
I reread LNPBP-4 because of this change and in fact, we will always have at least one commiment in the MPC. This change reflects the statement above, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
} -- U5 | ||
entropy is U64 | ||
cofactor is U16 | ||
messages map len=0..MAX24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to question above, we dont need at least one message in the merkle tree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. On one side no: we may have a merkle tree made of entropy (and its cross-section still will not be an empty set). However this has low utility, so it could be we can prohibit that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving a second thought: there might be a need to tress with no messages and just an entropy. While it's marginal, even if we require a non-empty message set, people can fake it and still produce trees containing no real messages. Thus, while it is mathematically impossible to have a tree cross-section which is empty, it is mathematically possible to have a tree with no messages, made only of entropy - thus, the difference in these types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for explanation.
No description provided.