Feature/lit 2570 js sdk fix build #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
requested review from
cairomassimo,
FedericoAmura and
MaximusHaximus
14 tasks
Nice catch! Thanks! |
Ansonhkg
added a commit
that referenced
this pull request
Feb 28, 2024
* init patch * Feature/lit 2570 js sdk fix build (#387) * feat: make capacityTokenId optional * chore: add test * fix: Conditionally include nft_id * fix: replace nx executor to @nrwl/js:tsc * fix: replace nx executor * feat: migrated nx to 15.9.0 * feat: migration nx from 15.9.0 -> 16.10.0 * feat: migrate nx to 17.3.0 * fix: yarn:test:unit command * chore: log cc nft token info * fix: undefined typings in package.json * remove old v0 errors from js sdk. provide error details to the user (#385) * remove old v0 errors from js sdk. provide error details to the user * building now seems to consistently work * refactored error handling to make it cleaner * Remove unused function * okay also added requestId in a few places * ran the linter * fix: replace nx executor * feat: add gitignore --------- Co-authored-by: Ansonhkg <[email protected]> * feat: cache enabled * chore: update .gitignore * chore: enable parallel * feat: make capacityTokenId optional (#384) * feat: make capacityTokenId optional * chore: add test * fix: Conditionally include nft_id * Update yarn.lock to match package.json changes * fix: ReferenceError: crypto is not defined * fix: ignore nx cache directory on linting * fix: ignore tools directory on linting * fix: linting * fix: ' ReferenceError: require is not defined in ES module scope, you can use import instead' * fix: lint * [Release] 3.2.2 * chore: move to manual tests --------- Co-authored-by: Chris Cassano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We replaced the Nx command executor with
@nrwl/js:tscfor the build command, moving away from_buildTsc. This change was made because the previous setup utilized the Nx command executor to build both TypeScript and vanilla packages. However, with the removal of the responsibility for bundling vanilla packages, the use of the Nx command executor is no longer necessary.This PR also migrated NX from version
14.5.10to17.3.0Type of change
How Has This Been Tested?
yarn buildDEBUG=true yarn test:e2e:node --filter=test-lit-action-1-sig.mjsChecklist: