Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental FROST/EdDSA signature combination #310

Closed
wants to merge 1 commit into from
Closed

add experimental FROST/EdDSA signature combination #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/constants/src/lib/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export enum SIGTYPE {
BLS = 'BLS',
EcdsaCaitSith = 'ECDSA_CAIT_SITH',
EcdsaCAITSITHP256 = 'EcdsaCaitSithP256',
FrostEd25519Sha512v1 = 'FROST-ED25519-SHA512-v1',
}

/**
Expand Down
66 changes: 66 additions & 0 deletions packages/crypto/src/lib/crypto.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,69 @@ describe('combine ECDSA Shares', () => {
expect(recoveredAddr).toEqual(addr);
});
});

describe('combine FROST Shares', () => {
beforeAll(async () => {
await initWasmEcdsaSdk();
});

it('Should recombine FROST signature shares', async () => {
const sigShares = [
{
sigType: 'FROST-ED25519-SHA512-v1',
dataSigned: '74657374',
signatureShare:
'a8272cf614b6af2c178575792574c438ad9b617d3aca925edd4f58419d307304',
verifyingShare:
'270e65d2e7d990c24d376b5fe008bcefe8638af62d38971e67b4c89bd2bdec07',
shareIndex:
'0100000000000000000000000000000000000000000000000000000000000000',
hidingNonce:
'8ded48acb6cb53aecc4c3db42881d68139899e87b3eee9eabd87d05a685d046d',
bindingNonce:
'2371452b8cce8907c5a056f468dad53149334de2098000a3f9c98badf48d99a0',
publicKey:
'899196af442a2c0d32d9c18b837a838379db18b37148bf35a4917202e0214658',
sigName: 'sig',
},
{
sigType: 'FROST-ED25519-SHA512-v1',
dataSigned: '74657374',
signatureShare:
'943afc49d0397adfea011b78f4963543be476aea4d1e4a35afb915bba3721c09',
verifyingShare:
'70f3807ea1c784f36fc900158a1c8ec3aaff7026be02e8edc0a2237c1eb73ccb',
shareIndex:
'0200000000000000000000000000000000000000000000000000000000000000',
hidingNonce:
'a895aa9a8e588caeb89d765c738df48a5f4be3fa6b91b953e0b7bce5074c54fc',
bindingNonce:
'e3b026a1b011c7e6a9d09ce2b4945cbac261a61ad2f43234993c12edf63a630c',
publicKey:
'899196af442a2c0d32d9c18b837a838379db18b37148bf35a4917202e0214658',
sigName: 'sig',
},
{
sigType: 'FROST-ED25519-SHA512-v1',
dataSigned: '74657374',
signatureShare:
'2527bed7775274fd49c72e94beddb2cb16be356db29ac5b8a1bc795fc714e402',
verifyingShare:
'3d6b6fdc64465c5d515770211fa981b799e3237b5d7023bf7f6a7e370add3ea7',
shareIndex:
'0300000000000000000000000000000000000000000000000000000000000000',
hidingNonce:
'7762508c2d030f72359daf77e82c9ecdc99d39a2f36f7d9cbc69ba9153e85013',
bindingNonce:
'1c2172836dc0b927e3d226458bd0be8d624cacca13fa82a258367eb025f41a38',
publicKey:
'899196af442a2c0d32d9c18b837a838379db18b37148bf35a4917202e0214658',
sigName: 'sig',
},
];

const sig = combineEcdsaShares(sigShares);

// TODO: the return type does not conform to CombinedECDSASignature
});
});
10 changes: 8 additions & 2 deletions packages/crypto/src/lib/crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export const combineEcdsaShares = (

/*
r and s values of the signature should be maximum of 64 bytes
r and s values can have polarity as the first two bits, here we remove
r and s values can have polarity as the first two bits, here we remove
*/
if (sig && sig.r && sig.r.length > 64) {
while (sig.r.length > 64) {
Expand All @@ -270,14 +270,20 @@ export const combineEcdsaShares = (
log('response from combine_signature', res);
sig = JSON.parse(res);
break;
case SIGTYPE.FrostEd25519Sha512v1:
res = ecdsaSdk.combine_signature(validShares, 4);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an update to the combiner that follows this new FrostEd25519Sha512v1 if so can you link that as well in this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Here: LIT-Protocol/lit-ecdsa-wasm-combine#5 (will add to the description as well)

log('response from combine_signature', res);
sig = JSON.parse(res);
// TODO(cairomassimo): the return type here does not conform to CombinedECDSASignature
break;
// if its another sig type, it shouldnt be resolving to this method
default:
throw new Error(
'Unsupported signature type present in signature shares. Please report this issue'
);
}
} catch (e) {
log('Failed to combine signatures:', e);
log('Failed to combine signatures:', e);
}

log('signature', sig);
Expand Down
Loading
Loading