Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental FROST/EdDSA signature combination #310

Conversation

cairomassimo
Copy link
Contributor

@cairomassimo cairomassimo commented Jan 19, 2024

Description

Adds support to combining FROST-type signature shares to the crypto package.

Relies on LIT-Protocol/lit-ecdsa-wasm-combine#5.

NOTE: the way this functionality is exposed in the api is not ideal, and only temporary. (Namely, it was added to the combineEcdsaShares method, despite we are not dealing with ECDSA, and the input/output types do not conform to the signature of that method.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Note: currently added to ECDSA-related methods, needs to be moved
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -270,14 +270,20 @@ export const combineEcdsaShares = (
log('response from combine_signature', res);
sig = JSON.parse(res);
break;
case SIGTYPE.FrostEd25519Sha512v1:
res = ecdsaSdk.combine_signature(validShares, 4);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an update to the combiner that follows this new FrostEd25519Sha512v1 if so can you link that as well in this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Here: LIT-Protocol/lit-ecdsa-wasm-combine#5 (will add to the description as well)

@joshLong145
Copy link

@cairomassimo
Can we start a feature branch for this work on https://linear.app/litprotocol/issue/LIT-2262/eddsa-and-schnorr
since this is being tracked as a project we can make a feature branch and merge it into that.

@cairomassimo
Copy link
Contributor Author

Closing in favor of #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants