Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/min exposure #150

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix/min exposure #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a543ce
added 'step=' and allows for the user to enter any step
capetillo Mar 25, 2024
d142d50
changed min value
capetillo Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/projects/CreateProjectForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,10 @@
size="is-small"
:disabled="!exposures[n-1].active || read_only"
type="number"
min="0"
min="0.000001"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Honestly in practice a min of 0.1 with step of 0.1 would probably suffice. I don't know that any of these cameras can control the exposure time in microseconds lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doing what Michael said is totally fine, just go with that.

max="100000"
step="any"
/>
<p class="control">
<span class="button is-static is-small">s</span>
</p>
</b-field>
<b-field
:label="n==1 ? 'Filter' : ''"
Expand Down Expand Up @@ -1090,7 +1088,6 @@ export default {
return index === indexToMatch ? { ...obj, [key]: val } : obj
})
},

clearProjectForm () {
this.modifying_existing_project = false
this.cloning_existing_project = false
Expand Down
Loading