Fix/min exposure #150
Merged
Fix/min exposure #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdaily
approved these changes
Mar 25, 2024
| @@ -322,12 +322,10 @@ | |||
| size="is-small" | |||
| :disabled="!exposures[n-1].active || read_only" | |||
| type="number" | |||
| min="0" | |||
| min="0.000001" | |||
There was a problem hiding this comment.
This is fine. Honestly in practice a min of 0.1 with step of 0.1 would probably suffice. I don't know that any of these cameras can control the exposure time in microseconds lol
There was a problem hiding this comment.
But doing what Michael said is totally fine, just go with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUICK FIX: Minimum exposure
Michael discovered that users cannot input decimals for exposures. This was quickly changed by changing the
minvalue of the Exposure field to be0.000001and having a step ofany. This step defaults to 1 but if the user wants to manually input something else, then that can be done too.