Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to local setup for sail #380

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Dec 15, 2023

New changes to https://github.com/maistra/istio-operator/tree/maistra-3.0 broke our make local-setup.

The operator became cluster scoped and relies on spec.namespace to be set in Istio CR.

TODO:

  • Currently investigating why service is not being created when we create the gateway - gateway does not become programmed

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #380 (515626c) into main (0a6b2c5) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   65.08%   65.16%   +0.07%     
==========================================
  Files          35       35              
  Lines        3795     3795              
==========================================
+ Hits         2470     2473       +3     
+ Misses       1129     1127       -2     
+ Partials      196      195       -1     
Flag Coverage Δ
integration 70.63% <ø> (+0.14%) ⬆️
unit 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.63% <ø> (+0.14%) ⬆️

see 4 files with indirect coverage changes

@adam-cattermole
Copy link
Member Author

The image for latest-3.0 was not tagged to the nightly build that included cluster-scoped changes. This resulted in us installing the newer manifests with the cluster-scoped changes but with an older operator image that wasn't handling it which resulted in the gateway not being reconciled.

Image has been re-tagged so the changes here work now.

@adam-cattermole adam-cattermole marked this pull request as ready for review December 15, 2023 16:23
@adam-cattermole adam-cattermole requested a review from a team as a code owner December 15, 2023 16:23
@adam-cattermole adam-cattermole merged commit 13b1ae3 into Kuadrant:main Dec 15, 2023
16 of 17 checks passed
@adam-cattermole adam-cattermole deleted the fix-sail-install branch December 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants