Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new quickstart script #373

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Dec 11, 2023

Adds a new quickstart script that can be run via the following command (for now while we wait on the MGC PR Kuadrant/multicluster-gateway-controller#731) we need to set it to use my branch):

export KUADRANT_ORG=adam-cattermole
export MGC_REF=update-quickstart
curl "https://raw.githubusercontent.com/adam-cattermole/kuadrant-operator/quickstart-script/hack/quickstart-setup.sh" | bash

You can then follow the guide at https://github.com/Kuadrant/kuadrant-operator/blob/main/doc/user-guides/secure-protect-connect.md

Resolves #370

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #373 (e4ae160) into main (13b1ae3) will decrease coverage by 0.93%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   66.03%   65.11%   -0.93%     
==========================================
  Files          35       35              
  Lines        3795     3795              
==========================================
- Hits         2506     2471      -35     
- Misses       1105     1130      +25     
- Partials      184      194      +10     
Flag Coverage Δ
integration 70.53% <ø> (-1.73%) ⬇️
unit 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.53% <ø> (-1.73%) ⬇️

see 5 files with indirect coverage changes

@adam-cattermole adam-cattermole marked this pull request as ready for review December 14, 2023 13:20
@adam-cattermole adam-cattermole requested a review from a team as a code owner December 14, 2023 13:20
@adam-cattermole adam-cattermole force-pushed the quickstart-script branch 2 times, most recently from b5670f0 to 9374745 Compare December 14, 2023 13:32
hack/quickstart-setup.sh Outdated Show resolved Hide resolved
@adam-cattermole adam-cattermole force-pushed the quickstart-script branch 2 times, most recently from f46767b to 3709a8b Compare December 14, 2023 16:05
@maleck13
Copy link
Collaborator

hack/quickstart-setup.sh Outdated Show resolved Hide resolved
@david-martin
Copy link
Member

👀

@maleck13
Copy link
Collaborator

This seems to fail quite early at the moment with the following message

The Istio "istiocontrolplane" is invalid: spec.namespace: Required value

@adam-cattermole
Copy link
Member Author

Work in progress fix here #380

@maleck13
Copy link
Collaborator

Is there a previous tag we could use that would keep this working and we can work towards supporting the changes then in a separate release?

@maleck13
Copy link
Collaborator

This worked well for me. However I have some local network issues and can't hit endpoints so I was going on the status of the resources and the DNS zone

@maleck13
Copy link
Collaborator

Once this merges we need to merge https://github.com/Kuadrant/docs.kuadrant.io/pull/44/files I am updating the quick start doc with the new env vars now

@maleck13
Copy link
Collaborator

@david-martin
Copy link
Member

I got through the script and guide to the end.
1 thing I noticed, that might be a misconfiguration on the RLP, is that both alice & bob are affected by the same limit i.e. 1 every 3 seconds.
From reading the RLP in the guide, should it be 2 every 3 seconds for bob?

$ while :; do curl -k --resolve api.${KUADRANT_ZONE_ROOT_DOMAIN}:443:${INGRESS_HOST} --write-out '%{http_code}\n' --silent --output /dev/null -H 'Authorization: APIKEY IAMALICE' "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" | grep -E --color "\b(429)\b|$"; sleep 1; done
200
429
429
200
429
429
200
429
429
200
^C

$ while :; do curl -k --resolve api.${KUADRANT_ZONE_ROOT_DOMAIN}:443:${INGRESS_HOST} --write-out '%{http_code}\n' --silent --output /dev/null -H 'Authorization: APIKEY IAMBOB' "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" | grep -E --color "\b(429)\b|$"; sleep 1; done
429
429
200
429
429
200
429
429
200
^C

@maleck13
Copy link
Collaborator

maleck13 commented Dec 18, 2023

@david-martin good spot. The RLP looks incorrect in the doc, I will update. Actually is looks like they are both getting 2 every 3?

Edit:
Actually it looks ok hmm maybe I am missing something
@eguzki can you validate the RLP in the walkthrough is correct?

@philbrookes
Copy link
Contributor

This is all working for me.

@maleck13
Copy link
Collaborator

going to merge this now we can update the doc if needed afterwards

@maleck13
Copy link
Collaborator

/lgtm

@adam-cattermole adam-cattermole merged commit 5c23f57 into Kuadrant:main Dec 18, 2023
16 checks passed
@adam-cattermole adam-cattermole deleted the quickstart-script branch December 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New single cluster quick start script in place that can be executed remotely
4 participants