-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix policy controller dependency #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 65.87% 65.05% -0.82%
==========================================
Files 35 35
Lines 3795 3795
==========================================
- Hits 2500 2469 -31
- Misses 1109 1131 +22
- Partials 186 195 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Changes look ok. @didierofrivia if we were to retag 0.3 would that solve the samples issue? |
@maleck13 yes, that'd solve the issue :) |
maleck13
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current issue of including the policy-controller manifests from main branch. It also, fixes the generation of manifests for the bundle and samples.
to create a new bundle:
The git diff should show, between other changes, the following:
While running just
make bundle
should not generate any changes.Notes:
POLICY_CONTROLLER_VERSION=0.3.0
since the multicluster-gateway-controller/config/samples/kustomization.yaml was not included in that released version but it's in main