Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Policy Controller to SHA builds #379

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

didierofrivia
Copy link
Member

Closes #376
Depends on #378

This PR does the following:

  1. Adds the policy controller to the scheduled builds daily
  2. Stores the latest sha tag in an org level variable

@didierofrivia didierofrivia added this to the v0.6.0 milestone Dec 15, 2023
@didierofrivia didierofrivia self-assigned this Dec 15, 2023
@didierofrivia didierofrivia marked this pull request as ready for review December 15, 2023 09:58
@didierofrivia didierofrivia requested a review from a team as a code owner December 15, 2023 09:58
@didierofrivia didierofrivia requested a review from pehala December 15, 2023 09:58
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #379 (f18eeec) into main (bf5fc99) will decrease coverage by 0.40%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   65.63%   65.24%   -0.40%     
==========================================
  Files          35       35              
  Lines        3795     3795              
==========================================
- Hits         2491     2476      -15     
- Misses       1115     1125      +10     
- Partials      189      194       +5     
Flag Coverage Δ
integration 70.77% <ø> (-0.75%) ⬇️
unit 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.77% <ø> (-0.75%) ⬇️

see 5 files with indirect coverage changes

@maleck13
Copy link
Collaborator

@didierofrivia should be able to use release-0.3 now it has been updated

Base automatically changed from fix-policy-controller-dependency to main December 18, 2023 10:22
@didierofrivia didierofrivia force-pushed the add-policy-controller-to-sha-builds branch from 48df02d to f18eeec Compare December 18, 2023 10:28
@didierofrivia didierofrivia merged commit 1bd09bc into main Dec 18, 2023
22 checks passed
@didierofrivia didierofrivia deleted the add-policy-controller-to-sha-builds branch December 18, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Policy controller does not have SHA in daily builds
3 participants