Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies to fix vulnerabilities #326

Closed
wants to merge 1 commit into from
Closed

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 22, 2023

bump istio.io/istio 1.20.0
bump google.golang.org/grpc v1.58.3

bump istio.io/istio 1.20.0
bump google.golang.org/grpc v1.58.3
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #326 (0bef184) into main (5a3be48) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   64.81%   64.81%           
=======================================
  Files          35       35           
  Lines        3786     3786           
=======================================
  Hits         2454     2454           
  Misses       1142     1142           
  Partials      190      190           
Flag Coverage Δ
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 70.64% <ø> (ø)

@alexsnaps
Copy link
Member

23-11-22T08:49:09.7386228Z �[0mRateLimitPolicy controller �[38;5;243mRLP targeting Gateway �[38;5;9m�[1m[It] Creates all the resources for a basic Gateway and RateLimitPolicy�[0m
2023-11-22T08:49:09.7387854Z �[38;5;243m/home/runner/work/kuadrant-operator/kuadrant-operator/controllers/ratelimitpolicy_controller_test.go:419�[0m
2023-11-22T08:49:09.7388599Z 
2023-11-22T08:49:09.7388800Z   �[38;5;9m[FAILED] Unexpected error:
2023-11-22T08:49:09.7389228Z       <*errors.StatusError | 0xc000f93cc0>: 
2023-11-22T08:49:09.7389861Z       wasmplugins.extensions.istio.io "kuadrant-toystore-gw" not found
2023-11-22T08:49:09.7390332Z       {
2023-11-22T08:49:09.7390582Z           ErrStatus: {
2023-11-22T08:49:09.7391125Z               TypeMeta: {Kind: "", APIVersion: ""},
2023-11-22T08:49:09.7391635Z               ListMeta: {
2023-11-22T08:49:09.7392386Z                   SelfLink: "",
2023-11-22T08:49:09.7392964Z                   ResourceVersion: "",
2023-11-22T08:49:09.7393384Z                   Continue: "",
2023-11-22T08:49:09.7393808Z                   RemainingItemCount: nil,
2023-11-22T08:49:09.7394160Z               },
2023-11-22T08:49:09.7394469Z               Status: "Failure",
2023-11-22T08:49:09.7395314Z               Message: "wasmplugins.extensions.istio.io \"kuadrant-toystore-gw\" not found",
2023-11-22T08:49:09.7396092Z               Reason: "NotFound",
2023-11-22T08:49:09.7396586Z               Details: {
2023-11-22T08:49:09.7397232Z                   Name: "kuadrant-toystore-gw",
2023-11-22T08:49:09.7397882Z                   Group: "extensions.istio.io",
2023-11-22T08:49:09.7398505Z                   Kind: "wasmplugins",
2023-11-22T08:49:09.7398893Z                   UID: "",
2023-11-22T08:49:09.7399311Z                   Causes: nil,
2023-11-22T08:49:09.7399869Z                   RetryAfterSeconds: 0,
2023-11-22T08:49:09.7400302Z               },
2023-11-22T08:49:09.7401010Z               Code: 404,
2023-11-22T08:49:09.7401479Z           },
2023-11-22T08:49:09.7401860Z       }
2023-11-22T08:49:09.7402190Z   occurred�[0m
2023-11-22T08:49:09.7404263Z   �[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/home/runner/work/kuadrant-operator/kuadrant-operator/controllers/ratelimitpolicy_controller_test.go:488�[0m �[38;5;243m@ 11/22/23 08:48:57.719�[0m

That's the issue I also ran into yesterday 🤔

@alexsnaps alexsnaps mentioned this pull request Nov 22, 2023
@alexsnaps alexsnaps added this to the v0.5.0 milestone Nov 22, 2023
@alexsnaps
Copy link
Member

Let's not do istio, as we don't need to, we depend on non vulnerable version, whatever dependabot says...
Also, we don't run that code anyways

@eguzki
Copy link
Contributor Author

eguzki commented Nov 22, 2023

We will try to remove istio.io/istio dep instead of bumping

@eguzki eguzki closed this Nov 22, 2023
@eguzki eguzki deleted the fix-vulnerabilities branch November 23, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: To test
Development

Successfully merging this pull request may close these issues.

3 participants