Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the deps #327

Closed
wants to merge 1 commit into from
Closed

Update all the deps #327

wants to merge 1 commit into from

Conversation

alexsnaps
Copy link
Member

@alexsnaps alexsnaps commented Nov 22, 2023

Lame attempt at upgrading all the things, but this has resulted in breaking an Integration test in my previous attempt, see how this goes this time around. We might also not want to update all the things…

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #327 (be1da9f) into main (342f3bf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files          35       35           
  Lines        3789     3789           
=======================================
  Hits         2451     2451           
  Misses       1148     1148           
  Partials      190      190           
Flag Coverage Δ
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 70.38% <ø> (ø)

@alexsnaps
Copy link
Member Author

Closing in favor of #326 - all deps don't solve our issue.

@alexsnaps alexsnaps closed this Nov 22, 2023
@eguzki eguzki deleted the deps branch December 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant