Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add LDO Leviathan v1.2 generic config #6415

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

meteyou
Copy link
Contributor

@meteyou meteyou commented Dec 2, 2023

This PR contains a generic config for the LDO Leviathan mainboard. I added the temperature sensors at the end because of the 2K2 pullup resistor. If this is not wanted, I can remove them.

@JamesH1978
Copy link
Collaborator

Thanks @meteyou for submitting this PR, can you clarify a couple of points? Is there a reason you chose watermark over pid for the bed? and what are these 2 extra temp sensors, are they extra adc ports seperate from the main extruder and heater ports?

Thanks
James

@meteyou
Copy link
Contributor Author

meteyou commented Dec 4, 2023

@JamesH1978 I just used the octopus pro as base config file. This was with watermark. I can switch to PID (like I use it in my printer).

Yes the leviathan has 4 ADC inputs. They are called TH0, TH1, TH2 and TH3. All 4 ports use a 2k2 pullup resistor. That's the reason why I added it in the config, that the user see the pullup resistor. If you have a better idea, I'm open to change it in the example file.

@JamesH1978
Copy link
Collaborator

makes sense, i would name the temperature sensors as such then, TH2 and TH3 so as not to cause confusion. Apart from those small changes, i cant see any reason not to approve

Thanks
James

@meteyou meteyou force-pushed the feat/add-ldo-leviathan branch 2 times, most recently from 7871873 to 67a6685 Compare December 4, 2023 22:01
@meteyou
Copy link
Contributor Author

meteyou commented Dec 4, 2023

@JamesH1978 i changed the heater_bed to PID and changed the names of the temperature_sensor to TH2 and TH3. i hope this will fit. feel free to ping me, if you have any other solutions/fixes.

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me apart from casing on th2, which is pedantry on my part ;)

Thanks
James

#[neopixel my_neopixel]
#pin: PF10 # NEOPIXEL

#[temperature_sensor th2]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casing on th2, nice to match the other and be TH2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh... thx for the hint! i fixed it!

@meteyou meteyou force-pushed the feat/add-ldo-leviathan branch from 67a6685 to 8cf6dad Compare December 5, 2023 20:53
Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good,

Thanks
James

@KevinOConnor KevinOConnor merged commit 7ed3c67 into Klipper3d:master Dec 6, 2023
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants