-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Centralized Package Management #798
Merged
KirillOsenkov
merged 3 commits into
KirillOsenkov:main
from
decriptor:use-centralized-package-management
Aug 18, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <MSBuildPackageVersion>17.5.0</MSBuildPackageVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="AdonisUI" Version="1.16.0" /> | ||
| <PackageVersion Include="AdonisUI.ClassicTheme" Version="1.16.0" /> | ||
| <PackageVersion Include="AutomaticGraphLayout.Drawing" Version="1.1.11" /> | ||
| <PackageVersion Include="AutomaticGraphLayout.WpfGraphControl" Version="1.1.11" /> | ||
| <PackageVersion Include="AvalonEdit" Version="6.3.0.90" /> | ||
| <PackageVersion Include="Avalonia.AvaloniaEdit" Version="11.0.6" /> | ||
| <PackageVersion Include="Avalonia.Desktop" Version="11.1.1" /> | ||
| <PackageVersion Include="Avalonia.Diagnostics" Version="11.1.1" /> | ||
| <PackageVersion Include="Avalonia.Themes.Fluent" Version="11.1.1" /> | ||
| <PackageVersion Include="DiffPlex" Version="1.7.0" /> | ||
| <PackageVersion Include="DotUtils.MsBuild.BinlogRedactor.SensitiveDataDetector" Version="0.0.8" /> | ||
| <PackageVersion Include="DotUtils.StreamUtils.Sources" Version="0.0.7" /> | ||
| <PackageVersion Include="FluentAssertions" Version="6.11.0" /> | ||
| <PackageVersion Include="GuiLabs.Language.Xml" Version="1.2.46" /> | ||
| <PackageVersion Include="HarfBuzzSharp" Version="2.8.2-preview.187" /> | ||
| <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" /> | ||
| <PackageVersion Include="Microsoft.Build" Version="$(MSBuildPackageVersion)" /> | ||
| <PackageVersion Include="Microsoft.Build.Framework" Version="$(MSBuildPackageVersion)" /> | ||
| <PackageVersion Include="Microsoft.Build.Locator" Version="1.4.1" /> | ||
| <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MSBuildPackageVersion)" /> | ||
| <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MSBuildPackageVersion)" /> | ||
| <PackageVersion Include="Microsoft.DotNet.ILCompiler" Version="7.0.0" /> | ||
| <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.0.0" /> | ||
| <PackageVersion Include="Mono.Cecil" Version="0.9.6.1" /> | ||
| <PackageVersion Include="MSBuild.StructuredLogger" Version="2.1.133" /> | ||
| <PackageVersion Include="Nerdbank.GitVersioning" Version="3.6.133" /> | ||
| <PackageVersion Include="Newtonsoft.Json" Version="13.0.1" /> | ||
| <PackageVersion Include="NuGet.ProjectModel" Version="6.8.0" /> | ||
| <PackageVersion Include="Nullable" Version="1.2.1" /> | ||
| <PackageVersion Include="SkiaSharp" Version="2.88.6" /> | ||
| <PackageVersion Include="SkiaSharp.NativeAssets.Linux" Version="2.88.6" /> | ||
| <PackageVersion Include="squirrel.windows" Version="1.4.4" /> | ||
| <PackageVersion Include="System.ComponentModel.TypeConverter" Version="4.3.0" /> | ||
| <PackageVersion Include="System.Collections.Immutable" Version="6.0.0" /> | ||
| <PackageVersion Include="System.Memory" Version="4.5.5" /> | ||
| <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" /> | ||
| <PackageVersion Include="System.Text.Json" Version="8.0.4" /> | ||
| <PackageVersion Include="System.Threading.Tasks.Dataflow" Version="6.0.0" /> | ||
| <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" /> | ||
| <PackageVersion Include="xunit" Version="2.4.1" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.1" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" /> | ||
| </packageSources> | ||
| </configuration> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that the NuGet package for MSBuild.StructuredLogger 2.2.317 is showing a dependency on Microsoft.SourceLink.GitHub 8.0.0, and I wonder if that was caused by the removal of PrivateAssets="all" here and whether that was intentional or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not intentional, I need to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published https://www.nuget.org/packages/MSBuild.StructuredLogger/2.2.337, thanks for spotting this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. Sorry for that.
@KirillOsenkov I was looking through the <TargetFramework(s)> and noticed that most of them are net8.0 with a couple others (net472, netstandard2.0, netcoreapp3.1). Is there any reason to not moving everything over to net8.0? (Or net9.0 in the near future?)
If we could move everything to net8.0 we could completely remove the SourceLink PackageReference: https://github.com/dotnet/sourcelink/releases/tag/8.0.0
If so, let me know and I'll create a PR for this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might not need to actually change the TFMs to use the inbox SourceLink - just ensuring it's all built with the .NET 8.0 SDK might be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Numpsy I'm not sure either. I err'ed on the side of it might be more beneficial to just move everything to net8.0?
The one thing I did forget about though is that this repo does generate some nuget packages, so to better support everyone out there it might not be practical to drop net472 or netstandard2.0?
I guess the only way to know for sure would be to test it out :) I'll see if I can do that this evening or in the near future because I've been wondering about that anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My request is to minimize contributions that don't solve real problems - maintaining this repo (among dozens of other repos I maintain) is already taking a huge toll on me, and PRs that look like help actually just cause more work for me in the future.
You can read here for a recent example:
#801 (comment)
So ideally if you feel that there's a real problem with the app, file an issue, and for issues that I need help with, I can mark them as up-for-grabs, and then feel free to send PRs for those.
My time and attention is incredibly scarce and valuable, so ideally I'd minimize interruptions and disruptions and pings as respect for my time and what I'm already doing for the community.
Thanks for your understanding!