Switch to Centralized Package Management

[decriptor]

I'm not sure if this is a change you'd like in the project. For the most part this only moves the package versions to the Directory.Packages.props file. There was maybe one or two places where the packages versions differed slightly, and I picked the newer version.

I wasn't able to run the app locally with or without these changes because of a System.IndexOutOfRangeException being thrown when trying add generic.xaml to the MergedDictionaries:

public MainWindow()
{
    InitializeComponent();

    var uri = new Uri("StructuredLogViewer;component/themes/Generic.xaml", UriKind.Relative);
    var generic = new ResourceDictionary { Source = uri };
    Application.Current.Resources.MergedDictionaries.Add(generic);

This'll most likely cause problems with #782. Once that PR is in, I can fix this one.

[KirillOsenkov]

Thanks! Are you running on Mac or Windows? Note that StructuredLogViewer.csproj will only work on Windows with WPF, for Mac you want the Avalonia csproj.

[KirillOsenkov]

Apologies for creating merge conflicts, but the Avalonia PR is more valuable and a lot of hard work went into that, so I gave it priority.

Was there an issue that you thought Central Package Version Management will fix? Or is it just clean-up level?

Not sure what's going on with the IndexOutOfRange, that code is for loading the dark theme.

[decriptor]

No worries. The Avalonia PR definitely needed to go in first.

This is mostly cleanup, but it does help clean up package versions and better keeps them in sync. There were a couple out of sync.

I'm planning on throwing a few more PRs up that are probably more "general" maintenance to start.

I'll try and update the PR this evening.

[decriptor]

I'm testing this out on Windows and dark theme.

[KirillOsenkov]

Actually I took the liberty to resolve the conflicts already, I pushed to your branch, will make sure it works and merge. Thanks!

[decriptor]

Actually I took the liberty to resolve the conflicts already, I pushed to your branch, will make sure it works and merge. Thanks!

Thanks!

[KirillOsenkov]

FYi @decriptor dotnet/wpf#9582

[decriptor]

Thanks! Good to know

[Numpsy]

I notice that the NuGet package for MSBuild.StructuredLogger 2.2.317 is showing a dependency on Microsoft.SourceLink.GitHub 8.0.0, and I wonder if that was caused by the removal of PrivateAssets="all" here and whether that was intentional or not?

[KirillOsenkov]

Probably not intentional, I need to fix

[KirillOsenkov]

Published https://www.nuget.org/packages/MSBuild.StructuredLogger/2.2.337, thanks for spotting this

[Numpsy]

Thanks

[decriptor]

My apologies. Sorry for that.

@KirillOsenkov I was looking through the <TargetFramework(s)> and noticed that most of them are net8.0 with a couple others (net472, netstandard2.0, netcoreapp3.1). Is there any reason to not moving everything over to net8.0? (Or net9.0 in the near future?)

If we could move everything to net8.0 we could completely remove the SourceLink PackageReference: https://github.com/dotnet/sourcelink/releases/tag/8.0.0

If so, let me know and I'll create a PR for this work.

[Numpsy]

You might not need to actually change the TFMs to use the inbox SourceLink - just ensuring it's all built with the .NET 8.0 SDK might be sufficient?

[decriptor]

@Numpsy I'm not sure either. I err'ed on the side of it might be more beneficial to just move everything to net8.0?

The one thing I did forget about though is that this repo does generate some nuget packages, so to better support everyone out there it might not be practical to drop net472 or netstandard2.0?

I guess the only way to know for sure would be to test it out :) I'll see if I can do that this evening or in the near future because I've been wondering about that anyways.

[KirillOsenkov]

My request is to minimize contributions that don't solve real problems - maintaining this repo (among dozens of other repos I maintain) is already taking a huge toll on me, and PRs that look like help actually just cause more work for me in the future.

You can read here for a recent example:
#801 (comment)

So ideally if you feel that there's a real problem with the app, file an issue, and for issues that I need help with, I can mark them as up-for-grabs, and then feel free to send PRs for those.

My time and attention is incredibly scarce and valuable, so ideally I'd minimize interruptions and disruptions and pings as respect for my time and what I'm already doing for the community.

Thanks for your understanding!