-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tutorial models #90
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c6ac5b3
Add link to glTF tutorial for Cameras
javagl d354d64
Add link to glTF tutorial for Triangle
javagl 07a4191
Add link to glTF tutorial for TriangleWithoutIndices
javagl 8f90cc1
Fix formatting and link in SimpleMeshes README
javagl f1f80a1
Add link to tutorial in SimpleMorph
javagl 91a6754
Add SimpleMaterial sample from tutorial
javagl 2c7b64c
Add SimpleTexture sample from tutorial
javagl 0879779
Add spaces in names of tutorial models
javagl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# LICENSE file for the model: SimpleMeshes | ||
|
||
All files in this directory tree are licensed as indicated below. | ||
|
||
* All files directly associated with the model including all text, image and binary files: | ||
|
||
* [CC0 1.0 Universal]("https://creativecommons.org/publicdomain/zero/1.0/legalcode") [SPDX license identifier: "CC0-1.0"] | ||
|
||
* This file and all other metadocumentation files including "metadata.json": | ||
|
||
* [Creative Commons Attribtution 4.0 International]("https://creativecommons.org/licenses/by/4.0/legalcode") [SPDX license identifier: "CC-BY-4.0"] | ||
|
||
Full license text of these licenses are available at the links above | ||
|
||
#### Generated by modelmetadata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
## Screenshot | ||
|
||
![screenshot](screenshot/screenshot.png) | ||
|
||
## Notes | ||
|
||
An example of a simple glTF asset with a PBR (physically based rendering) material definition, as described | ||
in the [Simple Material](https://github.com/KhronosGroup/glTF-Tutorials/blob/master/gltfTutorial/gltfTutorial_011_SimpleMaterial.md) | ||
section of the glTF tutorial. | ||
|
||
## Data layout | ||
|
||
The following image shows the data layout of this sample: | ||
|
||
![simpleTriangle](screenshot/simpleTriangle.png) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
{ | ||
"scene": 0, | ||
"scenes" : [ | ||
{ | ||
"nodes" : [ 0 ] | ||
} | ||
], | ||
|
||
"nodes" : [ | ||
{ | ||
"mesh" : 0 | ||
} | ||
], | ||
|
||
"meshes" : [ | ||
{ | ||
"primitives" : [ { | ||
"attributes" : { | ||
"POSITION" : 1 | ||
}, | ||
"indices" : 0, | ||
"material" : 0 | ||
} ] | ||
} | ||
], | ||
|
||
"buffers" : [ | ||
{ | ||
"uri" : "data:application/octet-stream;base64,AAABAAIAAAAAAAAAAAAAAAAAAAAAAIA/AAAAAAAAAAAAAAAAAACAPwAAAAA=", | ||
"byteLength" : 44 | ||
} | ||
], | ||
"bufferViews" : [ | ||
{ | ||
"buffer" : 0, | ||
"byteOffset" : 0, | ||
"byteLength" : 6, | ||
"target" : 34963 | ||
}, | ||
{ | ||
"buffer" : 0, | ||
"byteOffset" : 8, | ||
"byteLength" : 36, | ||
"target" : 34962 | ||
} | ||
], | ||
"accessors" : [ | ||
{ | ||
"bufferView" : 0, | ||
"byteOffset" : 0, | ||
"componentType" : 5123, | ||
"count" : 3, | ||
"type" : "SCALAR", | ||
"max" : [ 2 ], | ||
"min" : [ 0 ] | ||
}, | ||
{ | ||
"bufferView" : 1, | ||
"byteOffset" : 0, | ||
"componentType" : 5126, | ||
"count" : 3, | ||
"type" : "VEC3", | ||
"max" : [ 1.0, 1.0, 0.0 ], | ||
"min" : [ 0.0, 0.0, 0.0 ] | ||
} | ||
], | ||
|
||
"materials" : [ | ||
{ | ||
"pbrMetallicRoughness": { | ||
"baseColorFactor": [ 1.000, 0.766, 0.336, 1.0 ], | ||
"metallicFactor": 0.5, | ||
"roughnessFactor": 0.1 | ||
} | ||
} | ||
], | ||
"asset" : { | ||
"version" : "2.0" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
{ | ||
"scene": 0, | ||
"scenes" : [ | ||
{ | ||
"nodes" : [ 0 ] | ||
} | ||
], | ||
|
||
"nodes" : [ | ||
{ | ||
"mesh" : 0 | ||
} | ||
], | ||
|
||
"meshes" : [ | ||
{ | ||
"primitives" : [ { | ||
"attributes" : { | ||
"POSITION" : 1 | ||
}, | ||
"indices" : 0, | ||
"material" : 0 | ||
} ] | ||
} | ||
], | ||
|
||
"buffers" : [ | ||
{ | ||
"uri" : "triangle.bin", | ||
"byteLength" : 44 | ||
} | ||
], | ||
"bufferViews" : [ | ||
{ | ||
"buffer" : 0, | ||
"byteOffset" : 0, | ||
"byteLength" : 6, | ||
"target" : 34963 | ||
}, | ||
{ | ||
"buffer" : 0, | ||
"byteOffset" : 8, | ||
"byteLength" : 36, | ||
"target" : 34962 | ||
} | ||
], | ||
"accessors" : [ | ||
{ | ||
"bufferView" : 0, | ||
"byteOffset" : 0, | ||
"componentType" : 5123, | ||
"count" : 3, | ||
"type" : "SCALAR", | ||
"max" : [ 2 ], | ||
"min" : [ 0 ] | ||
}, | ||
{ | ||
"bufferView" : 1, | ||
"byteOffset" : 0, | ||
"componentType" : 5126, | ||
"count" : 3, | ||
"type" : "VEC3", | ||
"max" : [ 1.0, 1.0, 0.0 ], | ||
"min" : [ 0.0, 0.0, 0.0 ] | ||
} | ||
], | ||
|
||
"materials" : [ | ||
{ | ||
"pbrMetallicRoughness": { | ||
"baseColorFactor": [ 1.000, 0.766, 0.336, 1.0 ], | ||
"metallicFactor": 0.5, | ||
"roughnessFactor": 0.1 | ||
} | ||
} | ||
], | ||
"asset" : { | ||
"version" : "2.0" | ||
} | ||
} |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"version": 2, | ||
"legal": [ | ||
{ | ||
"license": "CC0", | ||
"licenseUrl": "https://creativecommons.org/publicdomain/zero/1.0/legalcode", | ||
"artist": "javagl", | ||
"year": "2017", | ||
"owner": "Public", | ||
"what": "Everything", | ||
"text": "CC0 1.0 Universal", | ||
"spdx": "CC0-1.0", | ||
"icon": "https://licensebuttons.net/p/zero/1.0/88x31.png" | ||
} | ||
], | ||
"tags": [ | ||
"core", | ||
"testing", | ||
"written" | ||
], | ||
"screenshot": "screenshot/screenshot.png", | ||
"name": "SimpleMaterial", | ||
"path": "./Models/SimpleMaterial", | ||
"summary": "A simple glTF asset with a material", | ||
"createReadme": true | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# LICENSE file for the model: SimpleMeshes | ||
|
||
All files in this directory tree are licensed as indicated below. | ||
|
||
* All files directly associated with the model including all text, image and binary files: | ||
|
||
* [CC0 1.0 Universal]("https://creativecommons.org/publicdomain/zero/1.0/legalcode") [SPDX license identifier: "CC0-1.0"] | ||
|
||
* This file and all other metadocumentation files including "metadata.json": | ||
|
||
* [Creative Commons Attribtution 4.0 International]("https://creativecommons.org/licenses/by/4.0/legalcode") [SPDX license identifier: "CC-BY-4.0"] | ||
|
||
Full license text of these licenses are available at the links above | ||
|
||
#### Generated by modelmetadata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
## Screenshot | ||
|
||
![screenshot](screenshot/screenshot.png) | ||
|
||
## Notes | ||
|
||
An example of a simple glTF asset with a texture, as described | ||
in the [Simple Texture](https://github.com/KhronosGroup/glTF-Tutorials/blob/master/gltfTutorial/gltfTutorial_013_SimpleTexture.md) | ||
section of the glTF tutorial. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
{ | ||
"scene": 0, | ||
"scenes" : [ { | ||
"nodes" : [ 0 ] | ||
} ], | ||
"nodes" : [ { | ||
"mesh" : 0 | ||
} ], | ||
"meshes" : [ { | ||
"primitives" : [ { | ||
"attributes" : { | ||
"POSITION" : 1, | ||
"TEXCOORD_0" : 2 | ||
}, | ||
"indices" : 0, | ||
"material" : 0 | ||
} ] | ||
} ], | ||
|
||
"materials" : [ { | ||
"pbrMetallicRoughness" : { | ||
"baseColorTexture" : { | ||
"index" : 0 | ||
}, | ||
"metallicFactor" : 0.0, | ||
"roughnessFactor" : 1.0 | ||
} | ||
} ], | ||
|
||
"textures" : [ { | ||
"sampler" : 0, | ||
"source" : 0 | ||
} ], | ||
"images" : [ { | ||
"uri" : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAQAAAAEACAYAAABccqhmAAAABHNCSVQICAgIfAhkiAAAAAlwSFlzAAAN1wAADdcBQiibeAAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAwaSURBVHic7dxfSJT5Hsfxj39a49jQlnA2z5gKa+FVS8nqLKxWs4V4ERgkWLJNu9DeBNEu23UE3QQbe9GSdeFFMNFlIBuLjTprm6E0MghLSDtauBHnXMT258xRGxfPRenmNuM4jz6jzvf9gt+Fzzi/mQf8vnlGx8mTNJMnicVi2VuFyhMAowgAYBgBAAwjAIBhBAAwLGkAXk3NZP+ZuMBXRN2wNHU5MguJFLOQ21cAuXxuQCZSzAIBACwgAIBhBAAwzI0ATE5O6ubNmxodHVVpaamam5vl8Xicb/g3ExMTc/t7vV41Nzdrw4YNi9+AACCLpqenFYlElEgkVF9fv6x7uzULjgMwNjamxsZGxWKxuWNer1fhcFjbtm1ztulbYrGYGhsbNTY2Nnds69atCofD+vDDDxe3CQGAy549e6ZgMKhQKKS+vj49f/5cJ0+eXNYAuDkLjgMQCAQUi8W0fft2NTU16fbt24pGozp8+LAGBgZUWFjobOM3Pv/8c42Njam6ulqNjY36+eefNTw8rLa2NvX396ugoCD9JgQALmttbVVXV5erj+HmLDgKQH9/v+7cuaOysjJFIhF5PB4lEgnt2rVLQ0NDunHjhlpaWjLf+I2+vj4NDAyooqJCkUhExcXFSiQS+uijjzQ4OKjOzk4dPHgw/UYEAC47cuSIvF6v6uvrNTIyovPnzy/r/m7PQn7S/xFM4/r165KkU6dOzb3mX7dunU6fPi1JunbtWvpNFrH/119/reLi4rn9v/3228z2X+n/tWSt/ZXG0aNH1dHRoWPHjqm0tDT9HTLk9iw4ugIYGRmRJO3cuXPe8ZqaGknS/fv3M9/Ujf0dnBuwmrg9C44C8PTpU0nSpk2b5h0vKSmR9PoXI0uxbPsTAKxxbs8C7wMALFjOAKxfv16SFI/H5x2f/Xr2tYpTy7Y/AcAa5/YsOPolYHl5uSTpwYMH847Pfr3U9wEs2/4r/Qsk1tpfK8ztWXAUgKamJknS5cuXNTPz179LXrlyRZLk9/sXvH84HFZ3d7eGh4cX3L+9vX3e8cXuP2elf3hYa3+5bKVnIU//fPdTgRP/Wfh/oOPxuKqrq/X48WMFAgEdOnRIoVBIFy9elMfj0fj4uDZu3Jj0vqOjo6qqqpIkBYNBtbW1vfM9L1++VHV1tZ48eaIvv/xSBw8eVFdXl3744Qe9//77Gh8fX9Rbjn0f5K34zw9rbS9fmlmIRqPq7OzUxMSEIpGIenp6VFNTo3379qmoqEh79+7Vnj17kt43m7OQSDkLHyQJwL/TfwhCKBTSgQMHNDU1NXesoKBAV69eTXoisy5duqQTJ05ox44dikajys/PT/p9P/30k5qbm/Xq1at5+weDQbW2tqZ9fpLk20IAWEtbvjSz4Pf7FQ6HU95eWVmphw8fJr0tm7OQSDELjv8KsH//ft29e1ft7e169OiRysvLdfz4cfl8vgXvN/u2yXPnzqU8Yen1pU9/f7/a29s1Pj6uiooKffXVV6qtrV38k3R4bsBiXbhwQbdu3Up5e11dXcrbVsMs5Kk0yRXAE3c+BmlqakolJSWqra1Vb2+vK4/xNt+/uAJgLW35cmQWEilmIavvAxgcHFQ8HteZM2ey84BZPDcgE6tlFrIagM2bN+vs2bPavXt3dh6QAGCVWi2zkKeyJC8Bfs+NT0L1beUlAGtpy5cjs5BIMQu8FRiwIMUsEADAgkwC8F5ljlw6EwAs0WCOz0JuXwEAWBABAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAwjAIBhBAAwjAAAhhEAwDACABhGAADDCABgGAEADCMAgGEEADCMAACGEQDAMAIAGEYAAMMIAGAYAQAMIwCAYQQAMIwAAIYRAMAwAgAYRgAAwwgAYBgBAAxLGoBXW2ey/0xc4PudumFp6nJkFhIpZiG3rwBy+dyATKSYBQIAWEAAAMMIAGCYGwGYnJzUzZs3NTo6qtLSUjU3N8vj8TjfMInp6Wndu3dPf/75pz799NPM7kwAkEXT09OKRCJKJBKqr693Zf/lngXHARgbG1NjY6NisdjcMa/Xq3A4rG3btjnb9I0//vhDwWBQoVBIfX19evHihb755hsCgFXn2bNn835Wnz9/rpMnTy5bANyeBccBCAQCisVi2r59u5qamnT79m1Fo1EdPnxYAwMDKiwsdLaxpJaWFvX09Di+/xwCAJe1traqq6vLtf3dngVHAejv79edO3dUVlamSCQij8ejRCKhXbt2aWhoSDdu3FBLS4vj59rW1qaKigo1NDTo119/1XfffedsIwIAlx05ckRer1f19fUaGRnR+fPnl3V/t2chX3lvbnx7pXH9+nVJ0qlTp+Ze869bt06nT5+WJF27ds3Zk3zjiy++UEdHhwKBgLZs2eJ8o2TnxmJlstI4evSoOjo6dOzYMZWWlqa/Q4bcngVHVwAjIyOSpJ07d847XlNTI0m6f/++8ye6nBycG5CTUsyCowA8ffpUkrRp06Z5x0tKSiS9/sXIqkAAgNeWMwBrRi6fG5CJ5QzA+vXrJUnxeHze8dmvi4uLM9/UDQQAeC3FLDj6JWB5ebkk6cGDB/OOz3691PcBLJuV/gUSa+2vXJHi/BwFoKmpSZJ0+fJlzcz89e+SV65ckST5/f4F7x8Oh9Xd3a3h4eGMzyMjK/3Dw1r7y2UrPQt5eqGZvx9PeBb+H+h4PK7q6mo9fvxYgUBAhw4dUigU0sWLF+XxeDQ+Pq6NGzcmve/o6KiqqqokScFgUG1tbe98z9DQkH788UdNTEzo3r176u3t1ccffyy/36+ioiJ99tlnamhoSHvOvpd5K/7zw1rby5dmFqLRqDo7OzUxMaFIJKKenh7V1NRo3759Kioq0t69e7Vnz56k983mLCRSzsLLJAHYkP5DEEKhkA4cOKCpqam5YwUFBbp69WrSE5l16dIlnThxQjt27FA0GlV+fv4739PQ0KBffvkl5R5VVVX67bff0j5H338JAGtpy5dmFvx+v8LhcMrbKysr9fDhw6S3ZXMWEilmwfFfAfbv36+7d++qvb1djx49Unl5uY4fPy6fz7fg/WbfNnnu3LmkJyxJ33//vbq7u1Pu8cknnyzuSTo8N2CxLly4oFu3bqW8va6uLuVtq2EW8hRPcgXwD3c+BmlqakolJSWqra1Vb2+vK4/xNt//uAJgLW35cmQWEilmIavvAxgcHFQ8HteZM2ey84BZPDcgE6tlFrIagM2bN+vs2bPavXt3dh6QAGCVWi2zkKfJJC8BinLjk1B9U7wEYC1t+XJkFhIpZoG3AgMWpJgFAgBYkEkA3pvOkUtnAoAlGszxWcjtKwAACyIAgGEEADCMAACG/R+qH8xoau6KiAAAAABJRU5ErkJggg==" | ||
} ], | ||
"samplers" : [ { | ||
"magFilter" : 9729, | ||
"minFilter" : 9987, | ||
"wrapS" : 33648, | ||
"wrapT" : 33648 | ||
} ], | ||
|
||
"buffers" : [ { | ||
"uri" : "data:application/gltf-buffer;base64,AAABAAIAAQADAAIAAAAAAAAAAAAAAAAAAACAPwAAAAAAAAAAAAAAAAAAgD8AAAAAAACAPwAAgD8AAAAAAAAAAAAAgD8AAAAAAACAPwAAgD8AAAAAAAAAAAAAAAAAAAAAAACAPwAAAAAAAAAA", | ||
"byteLength" : 108 | ||
} ], | ||
"bufferViews" : [ { | ||
"buffer" : 0, | ||
"byteOffset" : 0, | ||
"byteLength" : 12, | ||
"target" : 34963 | ||
}, { | ||
"buffer" : 0, | ||
"byteOffset" : 12, | ||
"byteLength" : 96, | ||
"byteStride" : 12, | ||
"target" : 34962 | ||
} ], | ||
"accessors" : [ { | ||
"bufferView" : 0, | ||
"byteOffset" : 0, | ||
"componentType" : 5123, | ||
"count" : 6, | ||
"type" : "SCALAR", | ||
"max" : [ 3 ], | ||
"min" : [ 0 ] | ||
}, { | ||
"bufferView" : 1, | ||
"byteOffset" : 0, | ||
"componentType" : 5126, | ||
"count" : 4, | ||
"type" : "VEC3", | ||
"max" : [ 1.0, 1.0, 0.0 ], | ||
"min" : [ 0.0, 0.0, 0.0 ] | ||
}, { | ||
"bufferView" : 1, | ||
"byteOffset" : 48, | ||
"componentType" : 5126, | ||
"count" : 4, | ||
"type" : "VEC2", | ||
"max" : [ 1.0, 1.0 ], | ||
"min" : [ 0.0, 0.0 ] | ||
} ], | ||
|
||
"asset" : { | ||
"version" : "2.0" | ||
} | ||
} |
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this name field should have a space.
"Simple Material"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this repo is very inconsistent about spaces in proper model names. But it has some, for example:
glTF-Sample-Assets/Models/BoxTexturedNonPowerOfTwo/metadata.json
Line 33 in 497c9c9