-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tutorial models #90
Conversation
Models/SimpleMaterial/metadata.json
Outdated
"written" | ||
], | ||
"screenshot": "screenshot/screenshot.png", | ||
"name": "SimpleMaterial", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this name field should have a space. "Simple Material"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this repo is very inconsistent about spaces in proper model names. But it has some, for example:
"name": "Box Textured not 2^N", |
Models/SimpleTexture/metadata.json
Outdated
"written" | ||
], | ||
"screenshot": "screenshot/screenshot.png", | ||
"name": "SimpleTexture", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise
@emackey It's actually not soooo inconsistent: Nearly every I just did that change for the newly added and previously existing "simple" (tutorial) models. A few short notes that might be related (also @DRx3D ):
(I'll note these as internal TODOs, but if desired, they can be escalated into issues, to prevent them sinking to the bottom of my TODO list...) |
Agreed. Also PotOfCoals has a |
Fixes #70
Some models that are shown in the glTF tutorial had been missing here. From the ones that are listed in the issue,
SimpleSkin
was already added a while ago. TheSimpleTexture
andSimpleMeshes
samples are added here.I also cleaned up some of the README.body.md files of the other tutorial models, and added links to the respective sections of the tutorial.
(I think the
LICENSE.md
files will be created/overwritten during the model index update - but it's all CC0, so there shouldn't be any changes anyhow...)