KhronosGroup · marty-johnson59 · Apr 8, 2024 · Mar 11, 2024 · Mar 14, 2024
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -55,7 +55,7 @@ ClangTidy:
     - docker
   script:
     - cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -Bbuild/clang
-    - python3 /usr/local/bin/run-clang-tidy.py -j $(($(nproc)/2+1)) -p build/clang -clang-tidy-binary=clang-tidy-10 -header-filter=framework,samples,vulkan_samples -checks=-*,google-*,-google-runtime-references -quiet framework/* samples/* vulkan_samples/* tests/*
+    - python3 /usr/local/bin/run-clang-tidy.py -j $(($(nproc)/2+1)) -p build/clang -clang-tidy-binary=clang-tidy-10 -isystem third_party -header-filter=framework,samples,vulkan_samples -checks=-*,google-*,-google-runtime-references -quiet framework/* samples/* vulkan_samples/* tests/*
 
 Linux:
   stage: Build

diff --git a/app/plugins/file_logger/file_logger.cpp b/app/plugins/file_logger/file_logger.cpp
@@ -1,5 +1,5 @@
-/* Copyright (c) 2021-2023, Arm Limited and Contributors
- * Copyright (c) 2021-2023, Sascha Willems
+/* Copyright (c) 2021-2024, Arm Limited and Contributors
+ * Copyright (c) 2021-2024, Sascha Willems
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -20,11 +20,9 @@
 
 #include "apps.h"
 
-VKBP_DISABLE_WARNINGS()
 #include <fmt/format.h>
 #include <spdlog/sinks/basic_file_sink.h>
 #include <spdlog/spdlog.h>
-VKBP_ENABLE_WARNINGS()
 
 namespace plugins
 {

diff --git a/components/core/include/core/util/error.hpp b/components/core/include/core/util/error.hpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2023, Thomas Atkinson
+/* Copyright (c) 2024, Thomas Atkinson
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -50,10 +50,8 @@
 		__pragma(warning(pop))
 #endif
 
-VKBP_DISABLE_WARNINGS()
 // TODO: replace with a direct fmt submodule
 #include <fmt/format.h>
-VKBP_ENABLE_WARNINGS()
 
 #include <stdexcept>
 

diff --git a/components/core/tests/strings.test.cpp b/components/core/tests/strings.test.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2023, Thomas Atkinson
+/* Copyright (c) 2024, Thomas Atkinson
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -17,9 +17,7 @@
 
 #include <core/util/error.hpp>
 
-VKBP_DISABLE_WARNINGS()
 #include <catch2/catch_test_macros.hpp>
-VKBP_ENABLE_WARNINGS()
 
 #include <core/util/strings.hpp>
 

diff --git a/framework/camera.h b/framework/camera.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019, Sascha Willems
+/* Copyright (c) 2019-2024, Sascha Willems
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -19,11 +19,9 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
 #include <glm/gtc/matrix_transform.hpp>
 #include <glm/gtc/quaternion.hpp>
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {

diff --git a/framework/common/helpers.h b/framework/common/helpers.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2018-2022, Arm Limited and Contributors
+/* Copyright (c) 2018-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -36,10 +36,8 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
 #include <glm/gtx/hash.hpp>
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {
@@ -102,7 +100,7 @@ inline void read(std::istringstream &is, std::array<T, N> &value)
 }
 
 template <typename T, typename... Args>
-inline void read(std::istringstream &is, T &first_arg, Args &... args)
+inline void read(std::istringstream &is, T &first_arg, Args &...args)
 {
 	read(is, first_arg);
 
@@ -157,7 +155,7 @@ inline void write(std::ostringstream &os, const std::array<T, N> &value)
 }
 
 template <typename T, typename... Args>
-inline void write(std::ostringstream &os, const T &first_arg, const Args &... args)
+inline void write(std::ostringstream &os, const T &first_arg, const Args &...args)
 {
 	write(os, first_arg);
 

diff --git a/framework/common/utils.h b/framework/common/utils.h
@@ -19,10 +19,8 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
 #include "glm/gtx/quaternion.hpp"
-VKBP_ENABLE_WARNINGS()
 
 #include "filesystem/legacy.h"
 #include "rendering/pipeline_state.h"

diff --git a/framework/core/command_buffer.cpp b/framework/core/command_buffer.cpp
@@ -23,9 +23,7 @@
 #include "rendering/render_frame.h"
 #include "rendering/subpass.h"
 
-VKBP_DISABLE_WARNINGS()
 #include <glm/gtc/type_ptr.hpp>
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {

diff --git a/framework/core/device.cpp b/framework/core/device.cpp
@@ -18,10 +18,8 @@
 
 #include "device.h"
 
-VKBP_DISABLE_WARNINGS()
 #define VMA_IMPLEMENTATION
 #include <vk_mem_alloc.h>
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {

diff --git a/framework/debug_info.h b/framework/debug_info.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2023, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -23,9 +23,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 #include "common/helpers.h"
 

diff --git a/framework/geometry/frustum.h b/framework/geometry/frustum.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2022, Sascha Willems
+/* Copyright (c) 2019-2024, Sascha Willems
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -21,9 +21,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {
@@ -38,7 +36,7 @@ enum Side
 };
 
 /**
- * @brief Represents a matrix by extracting its planes. Responsible for doing 
+ * @brief Represents a matrix by extracting its planes. Responsible for doing
  * intersection tests
  */
 class Frustum

diff --git a/framework/glsl_compiler.cpp b/framework/glsl_compiler.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2023, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -17,14 +17,12 @@
 
 #include "glsl_compiler.h"
 
-VKBP_DISABLE_WARNINGS()
 #include <SPIRV/GLSL.std.450.h>
 #include <SPIRV/GlslangToSpv.h>
 #include <StandAlone/DirStackFileIncluder.h>
 #include <glslang/Include/ShHandle.h>
 #include <glslang/OSDependent/osinclude.h>
 #include <glslang/Public/ResourceLimits.h>
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {

diff --git a/framework/glsl_compiler.h b/framework/glsl_compiler.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2020, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -22,9 +22,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include <glslang/Public/ShaderLang.h>
-VKBP_ENABLE_WARNINGS()
 
 #include "common/vk_common.h"
 #include "core/shader_module.h"
@@ -64,9 +62,9 @@ class GLSLCompiler
 	 */
 	bool compile_to_spirv(VkShaderStageFlagBits       stage,
 	                      const std::vector<uint8_t> &glsl_source,
-	                      const std::string &         entry_point,
-	                      const ShaderVariant &       shader_variant,
+	                      const std::string          &entry_point,
+	                      const ShaderVariant        &shader_variant,
 	                      std::vector<std::uint32_t> &spirv,
-	                      std::string &               info_log);
+	                      std::string                &info_log);
 };
 }        // namespace vkb
diff --git a/framework/gltf_loader.cpp b/framework/gltf_loader.cpp
@@ -24,10 +24,8 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
 #include <glm/gtc/type_ptr.hpp>
-VKBP_ENABLE_WARNINGS()
 
 #include "api_vulkan_sample.h"
 #include "common/utils.h"

diff --git a/framework/gui.cpp b/framework/gui.cpp
@@ -23,10 +23,8 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
 #include <glm/gtc/matrix_transform.hpp>
-VKBP_ENABLE_WARNINGS()
 
 #include "buffer_pool.h"
 #include "common/utils.h"

diff --git a/framework/heightmap.cpp b/framework/heightmap.cpp
@@ -21,9 +21,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 #include "filesystem/legacy.h"
 

diff --git a/framework/platform/android/android_platform.cpp b/framework/platform/android/android_platform.cpp
@@ -25,13 +25,11 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include <fmt/format.h>
 #include <imgui.h>
 #include <jni.h>
 #include <spdlog/sinks/android_sink.h>
 #include <spdlog/sinks/basic_file_sink.h>
-VKBP_ENABLE_WARNINGS()
 
 #include "apps.h"
 #include "common/strings.h"

diff --git a/framework/platform/glfw_window.cpp b/framework/platform/glfw_window.cpp
@@ -21,13 +21,11 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #define GLFW_INCLUDE_NONE
 #include <GLFW/glfw3.h>
 #include <GLFW/glfw3native.h>
 #include <fmt/format.h>
 #include <spdlog/sinks/stdout_color_sinks.h>
-VKBP_ENABLE_WARNINGS()
 
 #include "core/util/logging.hpp"
 #include "platform/platform.h"

diff --git a/framework/rendering/subpass.h b/framework/rendering/subpass.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2021, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -26,9 +26,7 @@
 #include "scene_graph/components/light.h"
 #include "scene_graph/node.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 namespace vkb
 {
@@ -141,8 +139,8 @@ class Subpass
 	void set_debug_name(const std::string &name);
 
 	/**
-	 * @brief Prepares the lighting state to have its lights 
-	 * 
+	 * @brief Prepares the lighting state to have its lights
+	 *
 	 * @tparam A light structure that has 'directional_lights', 'point_lights' and 'spot_light' array fields defined.
 	 * @param scene_lights All of the light components from the scene graph
 	 * @param light_count The maximum amount of lights allowed for any given type of light.
@@ -160,7 +158,7 @@ class Subpass
 		for (auto &scene_light : scene_lights)
 		{
 			const auto &properties = scene_light->get_properties();
-			auto &      transform  = scene_light->get_node()->get_transform();
+			auto       &transform  = scene_light->get_node()->get_transform();
 
 			Light light{{transform.get_translation(), static_cast<float>(scene_light->get_light_type())},
 			            {properties.color, properties.intensity},

diff --git a/framework/rendering/subpasses/geometry_subpass.h b/framework/rendering/subpasses/geometry_subpass.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2022, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -19,9 +19,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 #include "rendering/subpass.h"
 

diff --git a/framework/rendering/subpasses/lighting_subpass.h b/framework/rendering/subpasses/lighting_subpass.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2020, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -20,9 +20,7 @@
 #include "buffer_pool.h"
 #include "rendering/subpass.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 // This value is per type of light that we feed into the shader
 #define MAX_DEFERRED_LIGHT_COUNT 32

diff --git a/framework/scene_graph/components/aabb.h b/framework/scene_graph/components/aabb.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2018-2019, Arm Limited and Contributors
+/* Copyright (c) 2018-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -24,9 +24,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 #include "scene_graph/component.h"
 #include "scene_graph/components/sub_mesh.h"

diff --git a/framework/scene_graph/components/camera.h b/framework/scene_graph/components/camera.h
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2020, Arm Limited and Contributors
+/* Copyright (c) 2019-2024, Arm Limited and Contributors
  *
  * SPDX-License-Identifier: Apache-2.0
  *
@@ -24,9 +24,7 @@
 
 #include "common/error.h"
 
-VKBP_DISABLE_WARNINGS()
 #include "common/glm_common.h"
-VKBP_ENABLE_WARNINGS()
 
 #include "common/helpers.h"
 #include "scene_graph/component.h"