Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate warnings from includes via the third_party libraries. #974

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Mar 11, 2024

Description

Remove the need to use the VKBP_DISABLE_WARNINGS/VKBP_ENABLE_WARNINGS by marking all the third_party include folders as SYSTEM.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@jherico jherico force-pushed the thirdparty-warnings branch from 13273ba to e3f0359 Compare March 11, 2024 05:47
gary-sweet
gary-sweet previously approved these changes Mar 11, 2024
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gpx1000
gpx1000 previously approved these changes Mar 11, 2024
@jherico jherico dismissed stale reviews from gpx1000 and gary-sweet via 4b4be0a March 11, 2024 15:43
@jherico jherico force-pushed the thirdparty-warnings branch 2 times, most recently from 4b4be0a to e845e84 Compare March 11, 2024 15:55
@jherico jherico marked this pull request as ready for review March 11, 2024 15:55
Copy link
Collaborator

@tomadamatkinson tomadamatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! Cleans up a lot of repetitive stuff too. Thanks

@jherico jherico requested a review from gary-sweet March 11, 2024 22:20
gary-sweet
gary-sweet previously approved these changes Mar 12, 2024
asuessenbach
asuessenbach previously approved these changes Mar 14, 2024
@jherico jherico force-pushed the thirdparty-warnings branch from e845e84 to 19828ec Compare March 14, 2024 19:48
@jherico jherico force-pushed the thirdparty-warnings branch 2 times, most recently from 2770cb6 to ae50cdf Compare March 14, 2024 20:18
@jherico jherico force-pushed the thirdparty-warnings branch from ae50cdf to 7386618 Compare March 14, 2024 20:26
@marty-johnson59 marty-johnson59 merged commit dc7c1ae into KhronosGroup:main Apr 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants