-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate warnings from includes via the third_party libraries. #974
Merged
marty-johnson59
merged 2 commits into
KhronosGroup:main
from
jherico:thirdparty-warnings
Apr 8, 2024
Merged
Eliminate warnings from includes via the third_party libraries. #974
marty-johnson59
merged 2 commits into
KhronosGroup:main
from
jherico:thirdparty-warnings
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherico
force-pushed
the
thirdparty-warnings
branch
from
March 11, 2024 05:47
13273ba
to
e3f0359
Compare
gary-sweet
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gpx1000
previously approved these changes
Mar 11, 2024
jherico
force-pushed
the
thirdparty-warnings
branch
2 times, most recently
from
March 11, 2024 15:55
4b4be0a
to
e845e84
Compare
tomadamatkinson
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely! Cleans up a lot of repetitive stuff too. Thanks
gary-sweet
previously approved these changes
Mar 12, 2024
asuessenbach
previously approved these changes
Mar 14, 2024
jherico
dismissed stale reviews from asuessenbach, gary-sweet, and tomadamatkinson
via
March 14, 2024 19:48
19828ec
jherico
force-pushed
the
thirdparty-warnings
branch
from
March 14, 2024 19:48
e845e84
to
19828ec
Compare
jherico
force-pushed
the
thirdparty-warnings
branch
2 times, most recently
from
March 14, 2024 20:18
2770cb6
to
ae50cdf
Compare
jherico
force-pushed
the
thirdparty-warnings
branch
from
March 14, 2024 20:26
ae50cdf
to
7386618
Compare
asuessenbach
approved these changes
Mar 18, 2024
gary-sweet
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the need to use the
VKBP_DISABLE_WARNINGS
/VKBP_ENABLE_WARNINGS
by marking all the third_party include folders asSYSTEM
.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: