Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmc5160: expose drive_cs and adjust gscaler calculation #374

Closed
wants to merge 2 commits into from

Conversation

rogerlz
Copy link
Contributor

@rogerlz rogerlz commented Sep 23, 2024

This is a reimplementation of https://github.com/DangerKlippers/danger-klipper/pull/337. The goal is to expose the drive_cs parameter, allowing users to manually adjust the current scaling (CS value) while automatically calculating the appropriate GLOBALSCALER.

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@rogerlz rogerlz requested a review from a team as a code owner September 23, 2024 14:01
bwnance
bwnance previously approved these changes Sep 23, 2024
@rogerlz rogerlz marked this pull request as draft October 29, 2024 02:03
@wight554
Copy link

wight554 commented Dec 7, 2024

Any news on this PR?

@rogerlz
Copy link
Contributor Author

rogerlz commented Dec 17, 2024

it is being worked on here: #487

@rogerlz rogerlz closed this Dec 17, 2024
@rogerlz rogerlz deleted the feat/tmc5160cs branch December 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants