Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/#123/로그인 성공시 userid return #124

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Hotfix/#123/로그인 성공시 userid return #124

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628b219
Hotfix : 로컬 로그인 성공 시 userId 값 response에 추가
seongjunnoh Aug 18, 2024
b3ba6f8
hotfix : 카카오 로그인 성공 시 userId 값 response에 추가
seongjunnoh Aug 18, 2024
5612a38
refactor : 소셜 로그인 response dto 생성
seongjunnoh Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/space/space_spring/controller/OAuthController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class OAuthController {
* 유저가 카카오 로그인 동의 시 호출될 콜백 함수
*/
@GetMapping("/callback/kakao")
public BaseResponse<String> kakaoCallback(@RequestParam(name = "code") String code, HttpServletResponse response) {
public BaseResponse<Long> kakaoCallback(@RequestParam(name = "code") String code, HttpServletResponse response) {

// TODO 1. 인가코드 받기
// 카카오 인증 서버는 서비스 서버의 Redirect URI로 인가 코드를 전달함
Expand Down Expand Up @@ -70,6 +70,6 @@ public BaseResponse<String> kakaoCallback(@RequestParam(name = "code") String co
response.setHeader("Authorization", "Bearer " + jwtOAuthLogin);
log.info("jwtOAuthLogin = {}", jwtOAuthLogin);

return new BaseResponse<>("카카오 로그인 성공");
return new BaseResponse<>(userByOAuthInfo.getUserId());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3: 그럼 "result": 1 이런 형식으로 가는 건가요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! dto를 생성할까 했는데 그냥 바로 userId 값을 넘겨도 괜찮지 않을까 해서 이렇게 코드를 구성했습니다
혹시 response dto를 구성하는게 더 나을까요??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정확히 어떤 값인지 알기 위해서 명시해주는 것도 좋다고 생각합니다.
"userId : 1 이런 식으로요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 내용 반영해서 response dto 생성해서 userId를 전달하는 방식으로 추가 커밋 하였습니다!

}
}
Loading