Hotfix/#123/로그인 성공시 userid return #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunn522
approved these changes
Aug 18, 2024
| @@ -70,6 +70,6 @@ public BaseResponse<String> kakaoCallback(@RequestParam(name = "code") String co | |||
| response.setHeader("Authorization", "Bearer " + jwtOAuthLogin); | |||
| log.info("jwtOAuthLogin = {}", jwtOAuthLogin); | |||
|
|
|||
| return new BaseResponse<>("카카오 로그인 성공"); | |||
| return new BaseResponse<>(userByOAuthInfo.getUserId()); | |||
There was a problem hiding this comment.
p3: 그럼 "result": 1 이런 형식으로 가는 건가요??
There was a problem hiding this comment.
넵! dto를 생성할까 했는데 그냥 바로 userId 값을 넘겨도 괜찮지 않을까 해서 이렇게 코드를 구성했습니다
혹시 response dto를 구성하는게 더 나을까요??
There was a problem hiding this comment.
정확히 어떤 값인지 알기 위해서 명시해주는 것도 좋다고 생각합니다.
"userId : 1 이런 식으로요!
There was a problem hiding this comment.
리뷰 내용 반영해서 response dto 생성해서 userId를 전달하는 방식으로 추가 커밋 하였습니다!
drbug2000
approved these changes
Aug 18, 2024
| @@ -70,6 +70,6 @@ public BaseResponse<String> kakaoCallback(@RequestParam(name = "code") String co | |||
| response.setHeader("Authorization", "Bearer " + jwtOAuthLogin); | |||
| log.info("jwtOAuthLogin = {}", jwtOAuthLogin); | |||
|
|
|||
| return new BaseResponse<>("카카오 로그인 성공"); | |||
| return new BaseResponse<>(userByOAuthInfo.getUserId()); | |||
There was a problem hiding this comment.
정확히 어떤 값인지 알기 위해서 명시해주는 것도 좋다고 생각합니다.
"userId : 1 이런 식으로요!
seongjunnoh
added a commit
that referenced
this pull request
Oct 30, 2024
…turn Hotfix/#123/로그인 성공시 userid return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 요약
로컬 로그인, 소셜 로그인 시 response로 success msg 대신 userId 값을 보내주도록 수정
이슈 번호 : #123
🔖 변경 사항
✅ 리뷰 요구사항
📸 확인 방법 (선택)
📌 PR 진행 시 이러한 점들을 참고해 주세요