cxx-qt-lib: Add binding for QQmlApplicationEngine::loadFromModule #1141
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fall into the same fallacy as described here: #1140 (comment) due to using QAnyStringView. |
This function was added in Qt 6.5, as an alternative from loading files by file path.
redstrate
force-pushed
the
work/josh/add-loadfrommodule-binding
branch
from
3232bc3 to
88c6b25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
Comment on lines
+15
to
+16
| include!("cxx-qt-lib/qanystringview.h"); | ||
| type QAnyStringView<'a> = crate::QAnyStringView<'a>; |
There was a problem hiding this comment.
you need the cfg flags also here, although unsure if they work on include macros?
As this is a cxx::bridge rather than a cxx_qt::bridge I think the cfg flag should work on an extern block. It's only CXX-Qt bridges where we have the limitation of support only on certain items #1133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added in Qt 6.5, as an alternative from loading files by file path.