cxx-qt-lib: Add binding for QQmlApplicationEngine::singletonInstance #1140
Conversation
| void* | ||
| qqmlapplicationengineSingletonInstance(QQmlApplicationEngine& engine, QAnyStringView uri, QAnyStringView typeName) | ||
| { | ||
| return reinterpret_cast<void*>(engine.singletonInstance<QObject*>(uri, typeName)); |
There was a problem hiding this comment.
I kind of hate everything about this, but this somehow works. Suggestions appreciated, since I don't know of any other method supported in cxx-qt that has a template parameter.
There was a problem hiding this comment.
Hmm, once we have up/down casting and QObject already as a type #562 then this would be much easier. We would like this have this implemented in this cycle as it seems useful in multiple places.
It would be return a pointer to a QObject, then use the downcast_ptr method to get your original type back.
redstrate
force-pushed
the
work/josh/add-singletoninstance-binding
branch
from
02a5168 to
3a86460
Compare
redstrate
force-pushed
the
work/josh/add-singletoninstance-binding
branch
from
3a86460 to
1f6d532
Compare
This allows accessing QObject singleton instances registered in the QML engine (using #[qml_singleton]) from the Rust side.
redstrate
force-pushed
the
work/josh/add-singletoninstance-binding
branch
from
1f6d532 to
55647b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
| @@ -79,13 +82,33 @@ mod ffi { | |||
| ) -> Pin<&mut QQmlEngine>; | |||
| } | |||
|
|
|||
| #[cfg(any(cxxqt_qt_version_at_least_7, cxxqt_qt_version_at_least_6_5))] | |||
| unsafe extern "C++" { | |||
There was a problem hiding this comment.
This #[cfg] doesn't work I guess, so Qt5 and <6.5 builds will fail. A possible solution could be to separate this into a different cxx::bridge as suggested in this issue but that seems extreme?
This allows accessing QObject singleton instances registered in the QML engine (using #[qml_singleton]) from the Rust side.