Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive category filtering #3288

Merged
merged 8 commits into from
Oct 10, 2022
Merged

Comprehensive category filtering #3288

merged 8 commits into from
Oct 10, 2022

Conversation

rafalpawlow
Copy link
Contributor

Closes #3004

@rafalpawlow rafalpawlow marked this pull request as ready for review September 30, 2022 14:16
kdembler
kdembler reviewed Oct 3, 2022
View reviewed changes
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/hooks/useVideosInCategories.ts Outdated Show resolved Hide resolved
packages/atlas/src/hooks/useVideosInCategories.ts Outdated Show resolved Hide resolved
@rafalpawlow rafalpawlow requested a review from kdembler October 3, 2022 15:50
@kdembler kdembler mentioned this pull request Oct 3, 2022
Merged
kdembler
kdembler requested changes Oct 5, 2022
View reviewed changes
packages/atlas/src/components/FiltersBar/FiltersBar.tsx Outdated Show resolved Hide resolved
packages/atlas/src/config/categories.tsx Outdated Show resolved Hide resolved
packages/atlas/src/providers/videoWorkspace/hooks.ts Outdated Show resolved Hide resolved
packages/atlas/src/providers/videoWorkspace/provider.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/CategoryView/CategoryView.tsx Outdated Show resolved Hide resolved
packages/atlas/src/hooks/useVideoCategoriesWithCounter.ts Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/CategoryView/CategoryView.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/DiscoverView/DiscoverView.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/DiscoverView/DiscoverView.tsx Outdated Show resolved Hide resolved
@rafalpawlow rafalpawlow requested a review from kdembler October 5, 2022 13:13
@rafalpawlow rafalpawlow force-pushed the 3004-comprehensive-category-filtering branch from eaa3da4 to 365db54 Compare October 6, 2022 10:03
@rafalpawlow rafalpawlow marked this pull request as draft October 7, 2022 14:19
kdembler
kdembler requested changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's dragging out, but I've mentioned this change is gonna be complex 😅 Good news, it's all shaping up and even with the couple of comments I'm adding now, in general the change seems to work mostly properly, so we're close.

  1. Something is wrong with the category's video count pie chat. There are only 2 categories here and both have 3 videos so both should be filled in half:

CleanShot 2022-10-10 at 08 17 36@2x

2. Also:

CleanShot 2022-10-10 at 08 29 00@2x

packages/atlas/src/config/categories.ts Outdated Show resolved Hide resolved
packages/atlas/src/hooks/useVideoDisplayCategoriesWithCounter.ts Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/DiscoverView/DiscoverView.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/DiscoverView/DiscoverView.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/VideoView/MoreVideos.tsx Outdated Show resolved Hide resolved
@kdembler kdembler marked this pull request as ready for review October 10, 2022 06:38
@rafalpawlow rafalpawlow force-pushed the 3004-comprehensive-category-filtering branch from 692ee61 to 6786ddd Compare October 10, 2022 09:51
@rafalpawlow rafalpawlow requested a review from kdembler October 10, 2022 09:57
@kdembler kdembler merged commit da5e339 into Joystream:carthage Oct 10, 2022
@rafalpawlow rafalpawlow deleted the 3004-comprehensive-category-filtering branch October 12, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdembler kdembler kdembler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafalpawlow @kdembler @drillprop