Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all the app config into single YAML file #3293

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

kdembler
Copy link
Collaborator

@kdembler kdembler commented Oct 3, 2022

Part of #3105

Now the only config you need to provide is this single YAML file and URLs/secrets passed via env variables.

Very open to feedback and questions on this one, want to make this work as best as possible

Comment on lines +64 to +70
categories: # List of display categories to be used in the app. Those are local to the application and are related to metaprotocol categories via 'videoCategories' array.
- id: '1' # Local category ID
name: 'Music' # Display name of the category
color: '#D92E61' # Color used in the UI for this category
iconUrl: '...' # URL for category icon SVG
coverImgUrl: '...' # URL for category cover image
videoCategories: ['1', '2'] # List of metaprotocol category IDs that should be included in this display category
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get updated after work in #3288 is done

Copy link
Contributor

@drillprop drillprop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@drillprop drillprop merged commit ece5214 into Joystream:carthage Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants