-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move all the app config into single YAML file #3293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdembler
commented
Oct 3, 2022
Comment on lines
+64
to
+70
categories: # List of display categories to be used in the app. Those are local to the application and are related to metaprotocol categories via 'videoCategories' array. | ||
- id: '1' # Local category ID | ||
name: 'Music' # Display name of the category | ||
color: '#D92E61' # Color used in the UI for this category | ||
iconUrl: '...' # URL for category icon SVG | ||
coverImgUrl: '...' # URL for category cover image | ||
videoCategories: ['1', '2'] # List of metaprotocol category IDs that should be included in this display category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will get updated after work in #3288 is done
kdembler
force-pushed
the
operator-config
branch
from
October 4, 2022 12:51
8f15f1f
to
a70133c
Compare
kdembler
force-pushed
the
operator-config
branch
from
October 5, 2022 10:22
a70133c
to
ca79632
Compare
drillprop
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
rafalpawlow
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3105
Now the only config you need to provide is this single YAML file and URLs/secrets passed via env variables.
Very open to feedback and questions on this one, want to make this work as best as possible