Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-cedarling): make all tokens optional when calling Cedarling::authorize #10408

Closed
rmarinn opened this issue Dec 12, 2024 · 0 comments · Fixed by #10436
Closed

refactor(jans-cedarling): make all tokens optional when calling Cedarling::authorize #10408

rmarinn opened this issue Dec 12, 2024 · 0 comments · Fixed by #10436
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Milestone

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Dec 12, 2024

Is your feature request related to a problem? Please describe.

Cedarling currently requires all three tokens--access_token, id_token, userinfo_token -- for every request.

Describe the solution you'd like

Only one token is required, and the Cedarling should create the entities to the best of its ability based on the token(s) it has.

Additional context

  • check if if CEDARLING_USER_AUTHZ is enabled; if it is, then the user entity is required
  • check if CEDARLING_WORKLOAD_AUTHZ enabled; if it is, then the workload entity is required
  • if both CEDARLING_USER_AUTHZ and CEDARLING_WORKLOAD_AUTHZ is disabled, error on startup
@rmarinn rmarinn added comp-jans-cedarling Touching folder /jans-cedarling enhancement labels Dec 12, 2024
@rmarinn rmarinn assigned moabu and unassigned moabu Dec 12, 2024
@mo-auto mo-auto added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Dec 12, 2024
@nynymike nynymike changed the title refactor(jans-cedarling): make tokens optional refactor(jans-cedarling): Require only one token Dec 12, 2024
@rmarinn rmarinn changed the title refactor(jans-cedarling): Require only one token refactor(jans-cedarling): make all tokens optional when calling Cedarling::authorize Dec 12, 2024
@moabu moabu added this to the next-release milestone Dec 16, 2024
@olehbozhok olehbozhok self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
4 participants