Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): make tokens optional for sidecar #10461

Open
2 of 4 tasks
SafinWasi opened this issue Dec 19, 2024 · 0 comments
Open
2 of 4 tasks

feat(jans-cedarling): make tokens optional for sidecar #10461

SafinWasi opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Milestone

Comments

@SafinWasi
Copy link
Contributor


Description

As per the discussion in #10408, one to three tokens may be provided to input for cedarling instead of all 3 tokens being required. This depends on whether user or workload authorization is disabled, after which cedarling will create entities to the best of its ability. The mentioned PR must be merged before this can proceed.


Prepare

  • Read contribution guidelines
  • Read license information

Identified code changes

  • remove token checks

Test cases and code coverage

N/A


Document the changes

  • adjust sidecar example
@SafinWasi SafinWasi self-assigned this Dec 19, 2024
@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Dec 19, 2024
@moabu moabu modified the milestones: next-release, 1.2.0, next release Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Development

No branches or pull requests

3 participants