Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): implement toggle for Workload and User principals #10424

Closed
2 of 10 tasks
rmarinn opened this issue Dec 15, 2024 · 1 comment
Closed
2 of 10 tasks
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Milestone

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Dec 15, 2024


Description

We need to implement the following bootstrap configs:

  • CEDARLING_USER_AUTHZ: Enables Cedar engine authorization for a User principal.

  • CEDARLING_WORKLOAD_AUTHZ: Enables Cedar engine authorization is queried for a Workload principal.

  • Development target issue

target issue: refactor(jans-cedarling): make all tokens optional when calling Cedarling::authorize #10408

  • Implementation Details

To be able to make tokens optional when calling Cedarling::authorize, creating user and workload entities would also need to be optional since it's possible to create a Workload entity without creating a User entity depending on the given tokens and vice-versa.

To control if an Entity is required or not, the following bootstrap properties will be implemented

  • CEDARLING_USER_AUTHZ: Enables Cedar engine authorization for a User principal.
  • CEDARLING_WORKLOAD_AUTHZ: Enables Cedar engine authorization is queried for a Workload principal.

Prepare

  • Read contribution guidelines
  • Read license information

Identified code changes

  • implement CEDARLING_USER_AUTHZ bootstrap config
  • implement CEDARLING_WORKLOAD_AUTHZ bootstrap config

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@rmarinn rmarinn self-assigned this Dec 15, 2024
@rmarinn rmarinn added the comp-jans-cedarling Touching folder /jans-cedarling label Dec 15, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Dec 15, 2024
@moabu moabu added this to the next-release milestone Dec 16, 2024
@rmarinn
Copy link
Contributor Author

rmarinn commented Dec 17, 2024

will be implemented with #10408

@rmarinn rmarinn closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants