Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for scripts in fromProposalProcedure #978

Closed
wants to merge 1 commit into from
Closed

Add support for scripts in fromProposalProcedure #978

wants to merge 1 commit into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 25, 2024

Warning

On top of #971

Note

Requires IntersectMBO/cardano-api#692

Changelog

- description: |
    Add support for scripts in fromProposalProcedure
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes IntersectMBO/cardano-api#682

How to trust this PR

It's type change only

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Nov 25, 2024
@smelc smelc mentioned this pull request Nov 25, 2024
Merged
2 tasks
@smelc smelc changed the title Use new inject function instead of the XToY era functions Add support for scripts in fromProposalProcedure Nov 26, 2024
Base automatically changed from jordan/minting-script-witness-refactor to master November 26, 2024 14:17
@smelc
Copy link
Contributor Author

smelc commented Dec 6, 2024

Closing as this is superseded by #988

@smelc smelc closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 will be requested when the pull request is marked ready for review Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@palas palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

Assignees
No one assigned
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add support for scripts in fromProposalProcedure
1 participant
@smelc