Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromProposalProcedure: return StakeCredential #692

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 25, 2024

Changelog

- description: |
    fromProposalProcedure: return StakeCredential
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required for fixing #682

How to trust this PR

The only caller in CLI is perfectly having fromProposalProcedure returning a StakeCredential, as visible in IntersectMBO/cardano-cli#978.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/cl/change-from-proposal-procedure-return-type branch from 2e00faf to 9020d28 Compare November 26, 2024 20:25
@smelc smelc enabled auto-merge November 26, 2024 20:26
@smelc smelc added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024
@smelc smelc force-pushed the smelc/cl/change-from-proposal-procedure-return-type branch from 9020d28 to 19771e7 Compare November 26, 2024 21:15
@smelc smelc enabled auto-merge November 26, 2024 21:15
@smelc smelc added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024
@smelc smelc added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 715673d Nov 27, 2024
29 checks passed
@smelc smelc deleted the smelc/cl/change-from-proposal-procedure-return-type branch November 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants