-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-testnet-data: add --drep-keys flag #565
Conversation
69e1847
to
b434814
Compare
@@ -26,22 +39,16 @@ tree root = do | |||
subTrees <- mapM tree subs | |||
return $ files ++ concat subTrees | |||
|
|||
-- | This test tests the non-transient case, i.e. it maximizes the files | |||
-- that can be written to disk. Execute this test with: | |||
-- @cabal test cardano-cli-golden --test-options '-p "/golden create testnet data/'@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I always forget how this is done... Maybe we should add this to the CONTRIBUTING.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should add it somewhere too. I think this is the best place: https://github.com/input-output-hk/cardano-node-wiki/wiki/Running-tests
We can link from CONTRIBUTING.md
to it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added PR there: input-output-hk/cardano-node-wiki#37
@@ -54,6 +54,8 @@ hprop_golden_create_testnet_data = | |||
|
|||
H.diffVsGoldenFile generated'' "test/cardano-cli-golden/files/golden/conway/create-testnet-data.out" | |||
|
|||
-- | This test tests the non-transient case, i.e. it generates strictly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean it tests the transient case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, good catch 👍 Fixed 👍
@@ -11,6 +11,7 @@ | |||
|
|||
module Cardano.CLI.EraBased.Run.Governance.DRep | |||
( runGovernanceDRepCmds | |||
, runGovernanceDRepKeyGenCmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overindented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
runGovernanceDRepKeyGenCmd | ||
Cmd.GovernanceDRepKeyGenCmdArgs | ||
{ vkeyFile | ||
, skeyFile | ||
} = firstExceptT GovernanceCmdWriteFileError $ do | ||
} = do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underindented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed 👍
b434814
to
d0c54e2
Compare
…the keys. No registration, no delegation.
d0c54e2
to
1695d07
Compare
Changelog
Context
We cannot yet create the registration and the delegation for the dreps, but we'll need to generate keys when we do, and this first step will already help us remove some code in cardano-node here.
How to trust this PR
key-gen
backendChecklist