-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-testnet-data: various enhancements #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment
@@ -275,15 +275,19 @@ pGenesisCreateTestNetData envCli = | |||
Opt.optional $ fmap Lovelace $ Opt.option Opt.auto $ mconcat | |||
[ Opt.long "supply" | |||
, Opt.metavar "LOVELACE" | |||
, Opt.help "The initial coin supply in Lovelace which will be evenly distributed across initial, non-delegating stake holders. Defaults to 1 million Ada (i.e. 10^12 Lovelace)." | |||
, Opt.help $ unlines [ "The initial coin supply in Lovelace which will be evenly distributed across initial, non-delegating stake holders. Defaults to 1 million Ada (i.e. 10^12 Lovelace)." | |||
, " The total supply is this amount plus the amount specified with --supply-delegated." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing behaviour. --supply-delegated
shouldn't add to the total supply it should delegate a proportion (or all) of whatever was specified by --supply
. We should modify this behaviour in create-testnet-data
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me do that in another PR 👍 So removing the change to the help from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRed: #581
67f53c9
to
b072931
Compare
cardano-cli/test/cardano-cli-golden/Test/Golden/CreateTestnetData.hs
Outdated
Show resolved
Hide resolved
b072931
to
9a77245
Compare
9a77245
to
15a0fa1
Compare
Changelog
Context
This PR improves on a number of things, in particuler to make the user experience better (thinking of QA that will use this soon):
The documentation forWill be done differently in another PR in the end--supply
and--supply-delegated
is made more explicit, something requested many times by @CarlosLopezDeLaracreate-tesnet-data
are augmented a bitFixes #492
Checklist