Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename create-new-committee into update-committee #344

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 6, 2023

Changelog

- description: |
    Rename create-new-committee into update-committee
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #335

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Oct 6, 2023

cc @CarlosLopezDeLara

@smelc smelc marked this pull request as ready for review October 9, 2023 08:38
@CarlosLopezDeLara
Copy link
Contributor

cardano-cli conway governance action update-committee \
--testnet \
--governance-action-deposit 0 \
--stake-verification-key-file example/utxo-keys/stake1.vkey \
--proposal-url https://shorturl.at/asIJ6 \
--proposal-file example/transactions/cc_proposal.txt \
--add-cc-cold-verification-key-file example/cc/cold1-cc.vkey \
--epoch 202 \
--add-cc-cold-verification-key-file example/cc/cold2-cc.vkey \
--epoch 252 \
--quorum 51/100 \
--out-file example/transactions/update-committee.action
cat example/transactions/new-committee.action
{
    "type": "Governance proposal",
    "description": "",
    "cborHex": "8400581de05fd2fa72549639d76d48569eec31e63a5692e58375b2c708f27b299a8504f680a28200581c03fb852259ba0feb3f71ec2f5a108c133599d6a652aaed03590bcce318fc8200581cf7f2a37830d35650a6132f6bb9752e1967c158e842e3bbd5ac7b2a4818cad81e821833186482781968747470733a2f2f73686f727475726c2e61742f6173494a3658203d2a9d15382c14f5ca260a2f5bfb645fe148bfe10c1d0e1d305b7b1393e2bd97"
}
[0, h'E05FD2FA72549639D76D48569EEC31E63A5692E58375B2C708F27B299A', [4, null, [], {[0, h'03FB852259BA0FEB3F71EC2F5A108C133599D6A652AAED03590BCCE3']: 252, [0, h'F7F2A37830D35650A6132F6BB9752E1967C158E842E3BBD5AC7B2A48']: 202}, 30([51, 100])], ["https://shorturl.at/asIJ6", h'3D2A9D15382C14F5CA260A2F5BFB645FE148BFE10C1D0E1D305B7B1393E2BD97']]

@smelc smelc added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit b62b162 Oct 9, 2023
21 of 22 checks passed
@smelc smelc deleted the smelc/new-committee-becomes-update-committee branch October 9, 2023 19:08
@smelc
Copy link
Contributor Author

smelc commented Oct 18, 2023

@CarlosLopezDeLara> what is the output [0, h'E05FD2FA72549639D76D48569EEC31E63A5692E58375B2C708F27B299A', [4, null, [], {[0, h'03FB852259BA0FEB3F71EC2F5A108C133599D6A652AAED03590BCCE3']: 252, [0, h'F7F2A37830D35650A6132F6BB9752E1967C158E842E3BBD5AC7B2A48']: 202}, 30([51, 100])], ["https://shorturl.at/asIJ6", h'3D2A9D15382C14F5CA260A2F5BFB645FE148BFE10C1D0E1D305B7B1393E2BD97']] in your previous comment?

How did you generate it?

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Oct 18, 2023

@smelc

I bring the bytes on the text envelope 840058... to https://cbor.me/ and compare the result to the cddl

https://github.com/input-output-hk/cardano-ledger/blob/master/eras/conway/test-suite/cddl-files/conway.cddl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action create-new-committee needs amendment
2 participants