action create-new-committee needs amendment

[CarlosLopezDeLara]

cardano-cli conway governance action create-new-committee needs to be adjusted in concordance with IntersectMBO/cardano-ledger#3721 So we need 2 things:

• Rename create-new-committee to update-committee
  Make it be able to --remove-cc without forcing a replacement with an --add-cc as explained below Not an issue

[smelc]

For the record, as of a429d39, the output of cabal run cardano-cli -- conway governance action create-new-committee is as follows:

Usage: cardano-cli conway governance action create-new-committee 
                                                                   ( --mainnet
                                                                   | --testnet
                                                                   )
                                                                   --governance-action-deposit NATURAL
                                                                   ( --stake-pool-verification-key STRING
                                                                   | --cold-verification-key-file FILE
                                                                   | --stake-pool-id STAKE_POOL_ID
                                                                   | --stake-verification-key STRING
                                                                   | --stake-verification-key-file FILE
                                                                   | --stake-key-hash HASH
                                                                   )
                                                                   --proposal-url TEXT
                                                                   ( --proposal-text TEXT
                                                                   | --proposal-file FILE
                                                                   | --proposal-hash HASH
                                                                   )
                                                                   [ --remove-cc-cold-verification-key STRING
                                                                   | --remove-cc-cold-verification-key-file FILE
                                                                   | --remove-cc-cold-verification-key-hash STRING
                                                                   ]
                                                                   [
                                                                     ( --add-cc-cold-verification-key STRING
                                                                     | --add-cc-cold-verification-key-file FILE
                                                                     | --add-cc-cold-verification-key-hash STRING
                                                                     )
                                                                     --epoch NATURAL]
                                                                   --quorum RATIONAL
                                                                   [--governance-action-tx-id TXID
                                                                     --governance-action-index WORD32]
                                                                   --out-file FILE

  Create a new committee proposal.

Available options:
  --mainnet                Use the mainnet magic id.
  --testnet                Use the testnet magic id.
  --governance-action-deposit NATURAL
                           Deposit required to submit a governance action.
  --stake-pool-verification-key STRING
                           Stake pool verification key (Bech32 or hex-encoded).
  --cold-verification-key-file FILE
                           Filepath of the stake pool verification key.
  --stake-pool-id STAKE_POOL_ID
                           Stake pool ID/verification key hash (either
                           Bech32-encoded or hex-encoded). Zero or more
                           occurences of this option is allowed.
  --stake-verification-key STRING
                           Stake verification key (Bech32 or hex-encoded).
  --stake-verification-key-file FILE
                           Filepath of the staking verification key.
  --stake-key-hash HASH    Stake verification key hash (hex-encoded).
  --proposal-url TEXT      Proposal anchor URL
  --proposal-text TEXT     Input proposal as UTF-8 encoded text.
  --proposal-file FILE     Input proposal as a text file.
  --proposal-hash HASH     Proposal anchor data hash.
  --remove-cc-cold-verification-key STRING
                           Constitutional Committee cold key (hex-encoded).
  --remove-cc-cold-verification-key-file FILE
                           Filepath of the Consitutional Committee cold key.
  --remove-cc-cold-verification-key-hash STRING
                           Constitutional Committee key hash (hex-encoded).
  --add-cc-cold-verification-key STRING
                           Constitutional Committee cold key (hex-encoded).
  --add-cc-cold-verification-key-file FILE
                           Filepath of the Consitutional Committee cold key.
  --add-cc-cold-verification-key-hash STRING
                           Constitutional Committee key hash (hex-encoded).
  --epoch NATURAL          Committee member expiry epoch
  --quorum RATIONAL        Quorum of the committee that is necessary for a
                           successful vote.
  --governance-action-tx-id TXID
                           Previous txid of the governance action.
  --governance-action-index WORD32
                           Previous tx's governance action index.
  --out-file FILE          The output file.
  -h,--help                Show this help text

[smelc]

@CarlosLopezDeLara> at first sight, the presence of --add-cc-* flags is not related to the presence/absence of the --remove-cc-* flags. Both are declared with the 0 to many function (aptly named many): https://github.com/input-output-hk/cardano-cli/blob/3cf18089e99774b03832541111737a3e7d0d3f18/cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Actions.hs#L106

I'm still continuing to investigate though, because so far I'm unable to really reproduce your issue. I'm trying to do so using your scripts.

[smelc]

Draft PR: #344

It only does the create-new-commitee -> update-commitee change so far, until we clarify what we want with the parser (see Slack discussion).

[CarlosLopezDeLara]

We have confirmation that --remove-cc is a non-issue, therefore the issue is only about renaming to use ledger

cc @smelc

terminology.

cardano-cli conway governance action create-new-committee \
  --testnet \
  --governance-action-deposit 0 \
  --stake-verification-key-file utxo-keys/stake1.vkey \
  --proposal-url https://tinyurl.com/3wrwb2as \
  --proposal-file transactions/cc_proposal.txt \
  --remove-cc-cold-verification-key-file cc/cold1-cc.vkey \
  --quorum 51/100 \
  --out-file update-committee.action

[smelc]

@CarlosLopezDeLara> the PR to rename create-new-commitee into update-committee is there: #344