CI: shellcheck scripts

[smelc]

Changelog

- description: |
    CI: shellcheck scripts
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Bringing IntersectMBO/cardano-cli#734 and IntersectMBO/cardano-cli#737 to API

How to trust this PR

It's the same content as on CLI

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• Self-reviewed the diff

[carbolymer]

Why do you need shellcheck for building cardano-api-test? Shouldn't that go into shell.tools in line 78?

[smelc]

Because

(or because I copied how we were doing it in cardano-cli 😉)

[smelc]

@carbolymer> In the end I added shellcheck to shell.nativeBuildInputs, because shell.tools wanted me to specify a shellcheck version, which I don't want to do. We should take whatever version nixpkgs (or wherever it comes from) provides.

[Jimbo4350]

LGTM. @carbolymer has a comment.