Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all pipelines pass actionlint and remove useless bits in flake.nix #741

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Apr 25, 2024

Changelog

- description: |
    Make all pipelines file pass actionlint and remove useless bits in flake.nix
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Follow-up of #740 and IntersectMBO/cardano-api#525

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review April 25, 2024 13:24
@smelc smelc requested review from a team as code owners April 25, 2024 13:24
@smelc smelc changed the title Make all pipelines file pass actionlint and remove useless bits in flake.nix Make all pipelines pass actionlint and remove useless bits in flake.nix Apr 25, 2024
@@ -3,6 +3,7 @@ name: Check Stylish Haskell
on:
merge_group:
pull_request:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Contributor Author

@smelc smelc Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it, but I think it's good practice to be able to trigger the pipelines manually. It comes handy when the pipeline starts failing and needs quick trial/error fixing.

@smelc smelc added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 61647dd Apr 25, 2024
24 checks passed
@smelc smelc deleted the smelc/improvements-to-ci-and-nix branch April 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants