Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-api-internal: ProposeNewCommittee: StakeKey -> CommitteeColdKey #264

Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 22, 2023

Changelog

- description: |
    Make ProposeNewCommittee use the appropriate type of key
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required to implement this comment of IntersectMBO/cardano-cli#300.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment.

@smelc smelc force-pushed the smelc/new-committee-use-committee-cold-key-insteadof-stake-key branch from 3df7a7f to 5ef0f7c Compare September 25, 2023 07:12
@smelc smelc marked this pull request as ready for review September 25, 2023 07:13
@smelc smelc force-pushed the smelc/new-committee-use-committee-cold-key-insteadof-stake-key branch from 5ef0f7c to 9a19558 Compare September 25, 2023 07:20
@smelc smelc enabled auto-merge September 25, 2023 07:20
@smelc smelc added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit ddd7627 Sep 25, 2023
20 checks passed
@smelc smelc deleted the smelc/new-committee-use-committee-cold-key-insteadof-stake-key branch September 25, 2023 07:53
@smelc smelc mentioned this pull request Sep 25, 2023
10 tasks
L.KeyHashObj keyhash -> StakeKeyHash keyhash
fromCommitteeMember :: L.Credential ColdCommitteeRole StandardCrypto -> Hash CommitteeColdKey
fromCommitteeMember = \case
L.KeyHashObj keyhash -> CommitteeColdKeyHash keyhash
L.ScriptHashObj _scripthash -> error "TODO script committee members not yet supported"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have labelled this with TODO: Conway not a big deal though.

newhoggy added a commit that referenced this pull request Mar 11, 2024
…p-script-hash

Accept script hash in `stake-and-vote-delegation-certificate` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants