-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardano-api-internal: ProposeNewCommittee: StakeKey -> CommitteeColdKey #264
Merged
smelc
merged 1 commit into
main
from
smelc/new-committee-use-committee-cold-key-insteadof-stake-key
Sep 25, 2023
Merged
cardano-api-internal: ProposeNewCommittee: StakeKey -> CommitteeColdKey #264
smelc
merged 1 commit into
main
from
smelc/new-committee-use-committee-cold-key-insteadof-stake-key
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Jimbo4350
reviewed
Sep 22, 2023
cardano-api/internal/Cardano/Api/Governance/Actions/ProposalProcedure.hs
Show resolved
Hide resolved
Jimbo4350
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One comment.
smelc
force-pushed
the
smelc/new-committee-use-committee-cold-key-insteadof-stake-key
branch
from
September 25, 2023 07:12
3df7a7f
to
5ef0f7c
Compare
smelc
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
CarlosLopezDeLara and
disassembler
as code owners
September 25, 2023 07:13
…Key instead of StakeKey
smelc
force-pushed
the
smelc/new-committee-use-committee-cold-key-insteadof-stake-key
branch
from
September 25, 2023 07:20
5ef0f7c
to
9a19558
Compare
smelc
deleted the
smelc/new-committee-use-committee-cold-key-insteadof-stake-key
branch
September 25, 2023 07:53
10 tasks
Jimbo4350
reviewed
Sep 26, 2023
L.KeyHashObj keyhash -> StakeKeyHash keyhash | ||
fromCommitteeMember :: L.Credential ColdCommitteeRole StandardCrypto -> Hash CommitteeColdKey | ||
fromCommitteeMember = \case | ||
L.KeyHashObj keyhash -> CommitteeColdKeyHash keyhash | ||
L.ScriptHashObj _scripthash -> error "TODO script committee members not yet supported" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have labelled this with TODO: Conway
not a big deal though.
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…p-script-hash Accept script hash in `stake-and-vote-delegation-certificate` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Required to implement this comment of IntersectMBO/cardano-cli#300.
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7