Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-committee: use committee cold key #305

Closed
wants to merge 1 commit into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 22, 2023

Changelog

- description: |
    Make the `new-committee` command reach its final API (see [here](https://github.com/input-output-hk/cardano-cli/issues/300#issuecomment-1731004496))
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

⚠️ Depends on these PRs to be merged first 🚧

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@@ -102,8 +102,8 @@
<*> pAnyStakeIdentifier Nothing
<*> pProposalUrl
<*> pProposalHashSource
<*> many (pAnyStakeIdentifier (Just "remove-cc"))
<*> many ((,) <$> pAnyStakeIdentifier (Just "add-cc") <*> pEpochNo "Committee member expiry epoch")
<*> many (pCommitteeColdVerificationKeyOrHashOrFile {- (Just "remove-cc") -}) -- TODO replug prefix

Check warning

Code scanning / HLint

Redundant bracket

cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Actions.hs:105:14-81:&nbsp;Warning:&nbsp;Redundant&nbsp;bracket &nbsp;&nbsp; Found: &nbsp;&nbsp;(pCommitteeColdVerificationKeyOrHashOrFile) &nbsp;&nbsp; Perhaps: &nbsp;&nbsp;pCommitteeColdVerificationKeyOrHashOrFile
@smelc
Copy link
Contributor Author

smelc commented Sep 26, 2023

Closing in favor of #304

@smelc smelc closed this Sep 26, 2023
@smelc smelc deleted the smelc/new-committee-use-cold-committee-key-types branch February 1, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant