Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KDESKTOP-1223] Let the Windows CI runner manage the Sonar Cloud analysis, including code coverage #309

Merged
merged 18 commits into from
Oct 8, 2024
Merged

[KDESKTOP-1223] Let the Windows CI runner manage the Sonar Cloud analysis, including code coverage #309

merged 18 commits into from
Oct 8, 2024

Conversation

luc-guyot-infomaniak
Copy link
Contributor

No description provided.

@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as ready for review September 19, 2024 15:31
@luc-guyot-infomaniak luc-guyot-infomaniak requested a review from a team as a code owner September 19, 2024 15:31
@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as draft September 19, 2024 15:39
@herve-er herve-er added the 4.0.0 label Sep 20, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the kdesktop-1233-let-the-windows-ci-runner-launch-sonar-scanner-and-run-bullseye-coverage-analysis branch 2 times, most recently from 533eff9 to 8ae9dd5 Compare September 20, 2024 13:53
@herve-er herve-er added 3.6.7 and removed 4.0.0 labels Oct 1, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the kdesktop-1233-let-the-windows-ci-runner-launch-sonar-scanner-and-run-bullseye-coverage-analysis branch 2 times, most recently from 402c474 to 1d86f96 Compare October 4, 2024 13:48
@luc-guyot-infomaniak
Let cmake generate the compile commands json file
0425e62
@luc-guyot-infomaniak
Let the Windows CI runner launch the Sonar Cloud analysis, including …
19b9127 
…code coverage computation via Bullseye
@luc-guyot-infomaniak
Fixes Cmd and PowerShell commands for BullseyeCoverage activation
f0aaac3
@luc-guyot-infomaniak
Fixes the definition of the COVFILE environment variable
702ce4c
@luc-guyot-infomaniak
Removes quotes from environment variable as it causes a BullseyeCover…
3ce3e5c 
…age error
@luc-guyot-infomaniak
Sets the COVFILE environment variable before running unit tests
9210b4d
@luc-guyot-infomaniak
Runs sonar-scanner as a PowerShell command
f2f6451
@luc-guyot-infomaniak
Changes the sonar scanner installation action to v3
189b815
@luc-guyot-infomaniak
Changes the sonar scanner installation action to v2
cf099e5
@luc-guyot-infomaniak
Fixes the name of the github action for Sonar Source installation
66cf4b9
@luc-guyot-infomaniak
Loads the system Path into Github environment
ed8189c
@luc-guyot-infomaniak
Install Sonar Scanner sooner to speed up testing
0c605c1
@luc-guyot-infomaniak
Split the arguments of the sonnar-scanner command arguments
0c6c73c
@luc-guyot-infomaniak
Removes extra double-quote causing the Sonar scanner to fail
1388527
@luc-guyot-infomaniak
Adds sonar host url to the arguments of Sonar scanner
803271e
@luc-guyot-infomaniak
Fixes the name of the Sonar token (github secrets) for our Gihub Wind…
d7d1f6d 
…ows workflow
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the kdesktop-1233-let-the-windows-ci-runner-launch-sonar-scanner-and-run-bullseye-coverage-analysis branch from 0733622 to d7d1f6d Compare October 8, 2024 06:05
@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as ready for review October 8, 2024 06:05
@ClementKunz
Merge branch 'develop' into kdesktop-1233-let-the-windows-ci-runner-l…
de3cc17 
…aunch-sonar-scanner-and-run-bullseye-coverage-analysis
@ClementKunz
Merge branch 'develop' into kdesktop-1233-let-the-windows-ci-runner-l…
2276324 
…aunch-sonar-scanner-and-run-bullseye-coverage-analysis
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ClementKunz ClementKunz merged commit fe8493b into develop Oct 8, 2024
5 of 6 checks passed
@ClementKunz ClementKunz deleted the kdesktop-1233-let-the-windows-ci-runner-launch-sonar-scanner-and-run-bullseye-coverage-analysis branch October 8, 2024 11:24
@luc-guyot-infomaniak luc-guyot-infomaniak mentioned this pull request Oct 8, 2024
Closed
@luc-guyot-infomaniak luc-guyot-infomaniak added this to the 3.6.7 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementKunz ClementKunz ClementKunz approved these changes

@ChristopheLarchier ChristopheLarchier Awaiting requested review from ChristopheLarchier

@herve-er herve-er Awaiting requested review from herve-er

Assignees

@luc-guyot-infomaniak luc-guyot-infomaniak

Labels
3.6.7
Projects
None yet
Milestone
3.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@luc-guyot-infomaniak @ClementKunz @herve-er