Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KDESKTOP-962] Enable Sonar's CI Analysis on Linux with code coverage computation via Bullseye #303

Closed
wants to merge 10 commits into from
Closed

[KDESKTOP-962] Enable Sonar's CI Analysis on Linux with code coverage computation via Bullseye #303

wants to merge 10 commits into from

Conversation

luc-guyot-infomaniak
Copy link
Contributor

@luc-guyot-infomaniak luc-guyot-infomaniak commented Sep 18, 2024 •
edited
Loading

These changes enable the code coverage computation on the Linux CI worker.

Code coverage is only computed on the new code (Sonar Cloud default Quality Gate configuration).
The source directory src/3rdparty is excluded from coverage computation.

@luc-guyot-infomaniak luc-guyot-infomaniak mentioned this pull request Sep 18, 2024
Closed
@luc-guyot-infomaniak luc-guyot-infomaniak changed the title Enable Sonar's CI Analysis with code coverage computation via Bullseye [KDESKTOP-878] Enable Sonar's CI Analysis with code coverage computation via Bullseye Sep 18, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak changed the title [KDESKTOP-878] Enable Sonar's CI Analysis with code coverage computation via Bullseye [KDESKTOP-962] Enable Sonar's CI Analysis with code coverage computation via Bullseye Sep 18, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as ready for review September 18, 2024 14:37
@luc-guyot-infomaniak luc-guyot-infomaniak requested a review from a team as a code owner September 18, 2024 14:37
@ClementKunz ClementKunz added Review required but do not merge yet This PR is ready for review, however, it should not be merged before next release 4.0.0 and removed Review required but do not merge yet This PR is ready for review, however, it should not be merged before next release 4.0.0 labels Sep 19, 2024
@herve-er herve-er added Review required but do not merge yet This PR is ready for review, however, it should not be merged before next release 4.0.0 labels Sep 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@herve-er herve-er added 3.6.7 and removed 4.0.0 labels Oct 1, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak changed the title [KDESKTOP-962] Enable Sonar's CI Analysis with code coverage computation via Bullseye [KDESKTOP-962] Enable Sonar's CI Analysis on Linux with code coverage computation via Bullseye Oct 2, 2024
@ClementKunz ClementKunz removed the Review required but do not merge yet This PR is ready for review, however, it should not be merged before next release label Oct 8, 2024
@luc-guyot-infomaniak
Copy link
Contributor Author

Superseded by #309 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementKunz ClementKunz ClementKunz approved these changes

@ChristopheLarchier ChristopheLarchier ChristopheLarchier left review comments

Assignees

@luc-guyot-infomaniak luc-guyot-infomaniak

Labels
3.6.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luc-guyot-infomaniak @ClementKunz @ChristopheLarchier @herve-er