Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes all warnings about uninitialized member variables in constructors (cppcheck) #305

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Fixes all warnings about uninitialized member variables in constructors (cppcheck) #305

merged 6 commits into from
Oct 15, 2024

Conversation

luc-guyot-infomaniak
Copy link
Contributor

@luc-guyot-infomaniak luc-guyot-infomaniak commented Sep 19, 2024 •
edited
Loading

These changes make sure all non initialized member variables detected by cppcheck are initialized in constructors.

The following command was used:

cppcheck src  -isrc/3rdparty --output-file=check.txt --inconclusive --enable=warning --library=Qt --check-level=exhaustive -j6

@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as ready for review September 19, 2024 09:26
@luc-guyot-infomaniak luc-guyot-infomaniak requested a review from a team as a code owner September 19, 2024 09:26
@luc-guyot-infomaniak luc-guyot-infomaniak requested review from ChristopheLarchier, herve-er and ClementKunz and removed request for a team and herve-er September 19, 2024 09:39
@herve-er herve-er added the 4.0.0 label Sep 20, 2024
@herve-er herve-er added 3.6.7 and removed 4.0.0 labels Oct 1, 2024
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the fix-all-uninitialized-member-warnings-detected-by-cppcheck branch from 973b38a to 2e4abb8 Compare October 2, 2024 12:33
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the fix-all-uninitialized-member-warnings-detected-by-cppcheck branch from e0004e0 to 2649589 Compare October 14, 2024 14:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ClementKunz ClementKunz merged commit 720ebb6 into develop Oct 15, 2024
5 of 6 checks passed
@ClementKunz ClementKunz deleted the fix-all-uninitialized-member-warnings-detected-by-cppcheck branch October 15, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementKunz ClementKunz ClementKunz approved these changes

@ChristopheLarchier ChristopheLarchier Awaiting requested review from ChristopheLarchier

@herve-er herve-er Awaiting requested review from herve-er

Assignees

@luc-guyot-infomaniak luc-guyot-infomaniak

Labels
3.6.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luc-guyot-infomaniak @ClementKunz @ChristopheLarchier @herve-er