Skip to content

Commit

Permalink
Addresses Clément's review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
luc-guyot-infomaniak committed Oct 14, 2024
1 parent 805d338 commit 2649589
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
5 changes: 1 addition & 4 deletions src/libcommon/info/errorinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@

namespace KDC {

ErrorInfo::ErrorInfo() :
_time(0), _level(ErrorLevel::Unknown), _syncDbId(0), _exitCode(ExitCode::Unknown), _exitCause(ExitCause::Unknown),
_nodeType(NodeType::Unknown), _conflictType(ConflictType::None), _inconsistencyType(InconsistencyType::None),
_cancelType(CancelType::None) {}
ErrorInfo::ErrorInfo() {}

ErrorInfo::ErrorInfo(qint64 time, ErrorLevel level, const QString &functionName, int syncDbId, const QString &workerName,
ExitCode exitCode, ExitCause exitCause, const QString &localNodeId, const QString &remoteNodeId,
Expand Down
18 changes: 9 additions & 9 deletions src/libcommon/info/errorinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,21 +81,21 @@ class ErrorInfo {

private:
int _dbId{0};
qint64 _time;
ErrorLevel _level;
qint64 _time{0};
ErrorLevel _level{ErrorLevel::Unknown};
QString _functionName;
int _syncDbId;
int _syncDbId{0};
QString _workerName;
ExitCode _exitCode;
ExitCause _exitCause;
ExitCode _exitCode{ExitCode::Unknown};
ExitCause _exitCause{ExitCause::Unknown};
QString _localNodeId;
QString _remoteNodeId;
NodeType _nodeType;
NodeType _nodeType{NodeType::Unknown};
QString _path;
QString _destinationPath;
ConflictType _conflictType;
InconsistencyType _inconsistencyType;
CancelType _cancelType;
ConflictType _conflictType{ConflictType::None};
InconsistencyType _inconsistencyType{InconsistencyType::None};
CancelType _cancelType{CancelType::None};
bool _autoResolved{false};
};

Expand Down

0 comments on commit 2649589

Please sign in to comment.