feat: Save thread on kDrive #2088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasBourdin88
added
the
feature
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
from
1d9d5ed to
f003f01
Compare
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
5 times, most recently
from
a7184a0 to
9fcddcf
Compare
NicolasBourdin88
requested review from
FabianDevel
and removed request for
a team
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
2 times, most recently
from
7fe900c to
e5322cb
Compare
FabianDevel
requested changes
Nov 22, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadMessagesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/data/api/ApiRepository.kt
Outdated
Show resolved
Hide resolved
| @@ -1208,6 +1195,19 @@ class MainViewModel @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| fun getMessagesUidsFromThreadUids(selectedThreadsUuids: List<String>): List<String> { | |||
| val messageUids = mutableListOf<String>() | |||
| selectedThreadsUuids.forEach { threadUuid -> | |||
There was a problem hiding this comment.
This probably shouldn't be done on the main thread, maybe ask @sirambd to be sure.
But as the user could have a lots of thread and we're in a forEach, it could probably take too long to be done on the main thread
| } | ||
|
|
||
| fun getSubject(threadUuid: String): String? { | ||
| return threadController.getThread(threadUuid)?.subject |
There was a problem hiding this comment.
Same reflexion as above on the main thread
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
10 times, most recently
from
2d0899b to
c8d9269
Compare
FabianDevel
requested changes
Nov 22, 2024
| var postfix = 1 | ||
| var fileName = originalFileName | ||
|
|
||
| while (listFileName.contains(fileName)) fileName = "$originalFileName (${postfix++})" |
There was a problem hiding this comment.
We could probably optimized this function
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadProgressDialog.kt
Outdated
Show resolved
Hide resolved
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
3 times, most recently
from
a68b16c to
852fc8d
Compare
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
2 times, most recently
from
a923b3c to
becd775
Compare
NicolasBourdin88
force-pushed
the
save-thread-on-kDrive
branch
from
becd775 to
fdefc17
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to save messages and thread in kDrive